You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Adar Dembo (Code Review)" <ge...@cloudera.org> on 2019/05/27 02:57:38 UTC
[kudu-CR] nvm cache: fix initialization order warning
Hello Andrew Wong,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/13441
to review the following change.
Change subject: nvm_cache: fix initialization order warning
......................................................................
nvm_cache: fix initialization order warning
Change-Id: I6eb34de666c7000e740f0345b3abf876a84247dc
---
M src/kudu/util/nvm_cache.cc
1 file changed, 2 insertions(+), 3 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/41/13441/1
--
To view, visit http://gerrit.cloudera.org:8080/13441
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I6eb34de666c7000e740f0345b3abf876a84247dc
Gerrit-Change-Number: 13441
Gerrit-PatchSet: 1
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
[kudu-CR] nvm cache: fix initialization order warning
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13441 )
Change subject: nvm_cache: fix initialization order warning
......................................................................
nvm_cache: fix initialization order warning
Change-Id: I6eb34de666c7000e740f0345b3abf876a84247dc
Reviewed-on: http://gerrit.cloudera.org:8080/13441
Reviewed-by: Andrew Wong <aw...@cloudera.com>
Tested-by: Adar Dembo <ad...@cloudera.com>
---
M src/kudu/util/nvm_cache.cc
1 file changed, 2 insertions(+), 3 deletions(-)
Approvals:
Andrew Wong: Looks good to me, approved
Adar Dembo: Verified
--
To view, visit http://gerrit.cloudera.org:8080/13441
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I6eb34de666c7000e740f0345b3abf876a84247dc
Gerrit-Change-Number: 13441
Gerrit-PatchSet: 2
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: ye yuqiang <yu...@intel.com>
[kudu-CR] nvm cache: fix initialization order warning
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13441 )
Change subject: nvm_cache: fix initialization order warning
......................................................................
Patch Set 1: Verified+1
Overriding Jenkins, known flake and NTP desynchronization.
--
To view, visit http://gerrit.cloudera.org:8080/13441
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6eb34de666c7000e740f0345b3abf876a84247dc
Gerrit-Change-Number: 13441
Gerrit-PatchSet: 1
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: ye yuqiang <yu...@intel.com>
Gerrit-Comment-Date: Mon, 27 May 2019 22:04:11 +0000
Gerrit-HasComments: No
[kudu-CR] nvm cache: fix initialization order warning
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13441 )
Change subject: nvm_cache: fix initialization order warning
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/13441
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6eb34de666c7000e740f0345b3abf876a84247dc
Gerrit-Change-Number: 13441
Gerrit-PatchSet: 1
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: ye yuqiang <yu...@intel.com>
Gerrit-Comment-Date: Mon, 27 May 2019 02:59:20 +0000
Gerrit-HasComments: No
[kudu-CR] nvm cache: fix initialization order warning
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has removed Kudu Jenkins from this change. ( http://gerrit.cloudera.org:8080/13441 )
Change subject: nvm_cache: fix initialization order warning
......................................................................
Removed reviewer Kudu Jenkins with the following votes:
* Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/13441
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteReviewer
Gerrit-Change-Id: I6eb34de666c7000e740f0345b3abf876a84247dc
Gerrit-Change-Number: 13441
Gerrit-PatchSet: 1
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: ye yuqiang <yu...@intel.com>