[jira] [Commented] (HELIX-41) fix intermittent test failures

["Hudson (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HELIX-41?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13570060#comment-13570060 ] 

Hudson commented on HELIX-41:
-----------------------------

Integrated in helix #525 (See [https://builds.apache.org/job/helix/525/])
    HELIX-41: fix intermittent test failures (Revision c744c1b8b457488e48ef1cc08193662e61722e89)
HELIX-41: fix intermittent test failures (Revision ca1ef910820f938d8ff2f2f77d7f5c0c6b46e56a)
HELIX-41: fix intermittent test failures (Revision 18d2e636279f77af87dbc19dd3da2ba9132e040e)

     Result = UNSTABLE
zzhang : 
Files : 
* helix-core/src/test/java/org/apache/helix/store/zk/TestZkHelixPropertyStore.java
* helix-core/src/test/java/org/apache/helix/manager/zk/TestZkCacheAsyncOpSingleThread.java

zzhang : 
Files : 
* helix-core/src/test/java/org/apache/helix/integration/TestAddStateModelFactoryAfterConnect.java

zzhang : 
Files : 
* helix-core/src/test/java/org/apache/helix/healthcheck/TestAlertFireHistory.java

                
> fix intermittent test failures
> ------------------------------
>
>                 Key: HELIX-41
>                 URL: https://issues.apache.org/jira/browse/HELIX-41
>             Project: Apache Helix
>          Issue Type: Bug
>            Reporter: dafu
>            Assignee: dafu
>
> a few tests have the following pattern for assert test failure:
> sleep(xx) // wait zk callback to arrive or sth. similar
> assert(ret==true)
> but this depends on the zk callback latency and it's not stable.
> change it to:
> for (int i = 0; i < 10) {
>   if (ret == true)
>     break;
>   sleep(xx);
> }
> assert(ret == true)
> also in case of failure, we need to print out in assert(, "actual value that leads to failure") the actual value that leads to failure so we would know if the failure is caused by timeout or sth. else

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira