You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kafka.apache.org by Guozhang Wang <wa...@gmail.com> on 2015/03/19 21:35:24 UTC
Review Request 32258: Follow-up KAFKA-1910
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32258/
-----------------------------------------------------------
Review request for kafka.
Bugs: KAFKA-1910
https://issues.apache.org/jira/browse/KAFKA-1910
Repository: kafka
Description
-------
Fix two bugs 1) decompression on read 2) construct fetch partition data on node-id, plus some logging bugs.
Diffs
-----
clients/src/main/java/org/apache/kafka/clients/consumer/KafkaConsumer.java 2e2465326344585564800d2768f14c39d70a2e65
clients/src/main/java/org/apache/kafka/clients/consumer/internals/Fetcher.java 8b71fbad5c404d3f23137e153d6376de9f82b823
clients/src/main/java/org/apache/kafka/common/record/MemoryRecords.java c049bff305af8afb6315e448f5f092e39bb44c6d
clients/src/main/java/org/apache/kafka/common/record/Record.java 10df9fd8d3f4ec8c277650fa7eab269f3ea30d85
Diff: https://reviews.apache.org/r/32258/diff/
Testing
-------
Thanks,
Guozhang Wang
Re: Review Request 32258: Follow-up KAFKA-1910
Posted by Onur Karaman <ok...@linkedin.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32258/#review77114
-----------------------------------------------------------
Ship it!
clients/src/main/java/org/apache/kafka/common/record/MemoryRecords.java
<https://reviews.apache.org/r/32258/#comment125006>
Minor, but you might be able to replace this with:
```java
stream.readFully(recordBuffer, 0 size);
```
- Onur Karaman
On March 19, 2015, 8:35 p.m., Guozhang Wang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32258/
> -----------------------------------------------------------
>
> (Updated March 19, 2015, 8:35 p.m.)
>
>
> Review request for kafka.
>
>
> Bugs: KAFKA-1910
> https://issues.apache.org/jira/browse/KAFKA-1910
>
>
> Repository: kafka
>
>
> Description
> -------
>
> Fix two bugs 1) decompression on read 2) construct fetch partition data on node-id, plus some logging bugs.
>
>
> Diffs
> -----
>
> clients/src/main/java/org/apache/kafka/clients/consumer/KafkaConsumer.java 2e2465326344585564800d2768f14c39d70a2e65
> clients/src/main/java/org/apache/kafka/clients/consumer/internals/Fetcher.java 8b71fbad5c404d3f23137e153d6376de9f82b823
> clients/src/main/java/org/apache/kafka/common/record/MemoryRecords.java c049bff305af8afb6315e448f5f092e39bb44c6d
> clients/src/main/java/org/apache/kafka/common/record/Record.java 10df9fd8d3f4ec8c277650fa7eab269f3ea30d85
>
> Diff: https://reviews.apache.org/r/32258/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Guozhang Wang
>
>