[GitHub] [cordova-plugin-file] LightMind commented on pull request #461: FileWriter writes data in chunks, and converts ArrayBuffers to Base64. Fixes Issue #364

[GitBox <gi...@apache.org>]

LightMind commented on pull request #461:
URL: https://github.com/apache/cordova-plugin-file/pull/461#issuecomment-859593648


   @pietos I am happy that these changes helped you.
   
   Sorry that I have not been active on this issue. I think it's stable enough to be merged, but there are some points I feel I need to adres:
   
   * Users of the plugin might want to disable this behavior or control the chunk size
   * Documentation needs to explain that the writes are chunked, and if writes fail, the files can be in an inconsistent state.
   * Needs a unit-test that writes a file with size bigger than the chunk size, to check that the file is written consistently. Probably needs to check file sizes are that are
     - A multiple of the chunk size
     - A multiple of the chunk size + 1 / -1   
   
   In general, its not clear what should be done, if an error shows up, after we have written the first chunk, but before the last chunk is done writing.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org