You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by Jinmei Liao <ji...@pivotal.io> on 2016/07/13 16:33:46 UTC
Review Request 49992: GEODE-1571: use constructor instead of static
method to create security-manager and post-processor
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49992/
-----------------------------------------------------------
Review request for geode, Grace Meilen, Kevin Duling, and Kirk Lund.
Repository: geode
Description
-------
* use security-post-processor to specify the new PostProcessor
* use constructor instead of static method to create security-manager and post-processor
* fix tests
* This closes #198
Diffs
-----
geode-core/src/main/java/com/gemstone/gemfire/distributed/ConfigurationProperties.java 49a421a5e5e7eef3493cfe2c4bba62ea24609885
geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/AbstractDistributionConfig.java 8731fdc19b551a82fff8e21abdcb2a134b1c59fe
geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/DistributionConfig.java 71651d7461de205d3776391c669dbc5a098ba1bc
geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/DistributionConfigImpl.java 2b4cc5c34147716630da7979f2276a6ed32df612
geode-core/src/main/java/com/gemstone/gemfire/internal/security/GeodeSecurityUtil.java ecf16f624003f92d5bc5fb05441c204aa652364b
geode-core/src/main/java/com/gemstone/gemfire/internal/security/shiro/CustomAuthRealm.java f31189df2e12e254bb417d318395feef146cd428
geode-core/src/main/java/com/gemstone/gemfire/security/templates/SamplePostProcessor.java 8f13deb266ca212e20bb52050888041889bba38e
geode-core/src/main/java/com/gemstone/gemfire/security/templates/SampleSecurityManager.java 6f904c897d2950714d9c1409b8338a3c94c7a938
geode-core/src/test/java/com/gemstone/gemfire/distributed/internal/DistributionConfigJUnitTest.java aab46fb873a88d0f4083ba20e498b7e3a47585e0
geode-core/src/test/java/com/gemstone/gemfire/internal/security/GeodeSecurityUtilTest.java PRE-CREATION
geode-core/src/test/java/com/gemstone/gemfire/management/internal/security/GeodeSecurityUtilCustomRealmJUnitTest.java 8b174a4d33dbc09b7445dac554cb8bbb8c34ffbf
geode-core/src/test/java/com/gemstone/gemfire/management/internal/security/JSONAuthorization.java 31cb03e72e30f53fd10c7ea59526f737ed417270
geode-core/src/test/java/com/gemstone/gemfire/management/internal/security/JsonAuthorizationCacheStartRule.java 78ba97011ce7c5f896e9883f3602041cc939588d
geode-core/src/test/java/com/gemstone/gemfire/management/internal/security/MultiUserDUnitTest.java e645373297a75f8d2eb1d3b1ba8b2716a75dcc52
geode-core/src/test/java/com/gemstone/gemfire/security/AbstractIntegratedClientAuthDistributedTest.java 45ecfe0c5da74fdc8cd4ecda16ee85d26ff9a712
geode-core/src/test/java/com/gemstone/gemfire/security/IntegratedSecurityCacheLifecycleDistributedTest.java 6634f171360a2847d5231e8e3a01bc1b7693f060
geode-core/src/test/java/com/gemstone/gemfire/security/IntegratedSecurityCacheLifecycleIntegrationTest.java 0b97888f56e8f5d9b577388bc24825b14dd36b85
geode-core/src/test/java/com/gemstone/gemfire/security/NoShowValue1PostProcessor.java bca971787262cce3a2c794b985156a8d7d64dda1
geode-pulse/src/test/java/com/vmware/gemfire/tools/pulse/tests/Server.java 9356eb925c9feaa682de48c51e984fef25bd56d8
Diff: https://reviews.apache.org/r/49992/diff/
Testing
-------
Thanks,
Jinmei Liao
Re: Review Request 49992: GEODE-1571: use constructor instead of
static method to create security-manager and post-processor
Posted by Kirk Lund <ki...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49992/#review142252
-----------------------------------------------------------
Ship it!
Ship It!
- Kirk Lund
On July 13, 2016, 4:33 p.m., Jinmei Liao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49992/
> -----------------------------------------------------------
>
> (Updated July 13, 2016, 4:33 p.m.)
>
>
> Review request for geode, Grace Meilen, Kevin Duling, and Kirk Lund.
>
>
> Repository: geode
>
>
> Description
> -------
>
> * use security-post-processor to specify the new PostProcessor
> * use constructor instead of static method to create security-manager and post-processor
> * fix tests
> * This closes #198
>
>
> Diffs
> -----
>
> geode-core/src/main/java/com/gemstone/gemfire/distributed/ConfigurationProperties.java 49a421a5e5e7eef3493cfe2c4bba62ea24609885
> geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/AbstractDistributionConfig.java 8731fdc19b551a82fff8e21abdcb2a134b1c59fe
> geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/DistributionConfig.java 71651d7461de205d3776391c669dbc5a098ba1bc
> geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/DistributionConfigImpl.java 2b4cc5c34147716630da7979f2276a6ed32df612
> geode-core/src/main/java/com/gemstone/gemfire/internal/security/GeodeSecurityUtil.java ecf16f624003f92d5bc5fb05441c204aa652364b
> geode-core/src/main/java/com/gemstone/gemfire/internal/security/shiro/CustomAuthRealm.java f31189df2e12e254bb417d318395feef146cd428
> geode-core/src/main/java/com/gemstone/gemfire/security/templates/SamplePostProcessor.java 8f13deb266ca212e20bb52050888041889bba38e
> geode-core/src/main/java/com/gemstone/gemfire/security/templates/SampleSecurityManager.java 6f904c897d2950714d9c1409b8338a3c94c7a938
> geode-core/src/test/java/com/gemstone/gemfire/distributed/internal/DistributionConfigJUnitTest.java aab46fb873a88d0f4083ba20e498b7e3a47585e0
> geode-core/src/test/java/com/gemstone/gemfire/internal/security/GeodeSecurityUtilTest.java PRE-CREATION
> geode-core/src/test/java/com/gemstone/gemfire/management/internal/security/GeodeSecurityUtilCustomRealmJUnitTest.java 8b174a4d33dbc09b7445dac554cb8bbb8c34ffbf
> geode-core/src/test/java/com/gemstone/gemfire/management/internal/security/JSONAuthorization.java 31cb03e72e30f53fd10c7ea59526f737ed417270
> geode-core/src/test/java/com/gemstone/gemfire/management/internal/security/JsonAuthorizationCacheStartRule.java 78ba97011ce7c5f896e9883f3602041cc939588d
> geode-core/src/test/java/com/gemstone/gemfire/management/internal/security/MultiUserDUnitTest.java e645373297a75f8d2eb1d3b1ba8b2716a75dcc52
> geode-core/src/test/java/com/gemstone/gemfire/security/AbstractIntegratedClientAuthDistributedTest.java 45ecfe0c5da74fdc8cd4ecda16ee85d26ff9a712
> geode-core/src/test/java/com/gemstone/gemfire/security/IntegratedSecurityCacheLifecycleDistributedTest.java 6634f171360a2847d5231e8e3a01bc1b7693f060
> geode-core/src/test/java/com/gemstone/gemfire/security/IntegratedSecurityCacheLifecycleIntegrationTest.java 0b97888f56e8f5d9b577388bc24825b14dd36b85
> geode-core/src/test/java/com/gemstone/gemfire/security/NoShowValue1PostProcessor.java bca971787262cce3a2c794b985156a8d7d64dda1
> geode-pulse/src/test/java/com/vmware/gemfire/tools/pulse/tests/Server.java 9356eb925c9feaa682de48c51e984fef25bd56d8
>
> Diff: https://reviews.apache.org/r/49992/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jinmei Liao
>
>