You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2020/06/12 01:51:14 UTC

[GitHub] [hadoop-ozone] runzhiwang opened a new pull request #1066: HDDS-3770. Improve getPipelines performance

runzhiwang opened a new pull request #1066:
URL: https://github.com/apache/hadoop-ozone/pull/1066


   ## What changes were proposed in this pull request?
   
   1. getPipelines is in the critical path of allocateBlock, and discardPipeline is the hot spot in getPipelines.
   2. Change `List` to `Set` to make `add`  and `contain` faster.
   3. Remove stream().filter().collect()
   
   
   ## What is the link to the Apache JIRA
   
   https://issues.apache.org/jira/browse/HDDS-3770?filter=-2
   
   ## How was this patch tested?
   
   Existed tests.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org

[GitHub] [hadoop-ozone] codecov-commenter commented on pull request #1066: HDDS-3770. Improve getPipelines performance

Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #1066:
URL: https://github.com/apache/hadoop-ozone/pull/1066#issuecomment-643062826


   # [Codecov](https://codecov.io/gh/apache/hadoop-ozone/pull/1066?src=pr&el=h1) Report
   > Merging [#1066](https://codecov.io/gh/apache/hadoop-ozone/pull/1066?src=pr&el=desc) into [master](https://codecov.io/gh/apache/hadoop-ozone/commit/cee76a891b21ea50884ad8ba14461b31f60494ea&el=desc) will **decrease** coverage by `0.10%`.
   > The diff coverage is `50.94%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/hadoop-ozone/pull/1066/graphs/tree.svg?width=650&height=150&src=pr&token=5YeeptJMby)](https://codecov.io/gh/apache/hadoop-ozone/pull/1066?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #1066      +/-   ##
   ============================================
   - Coverage     69.46%   69.35%   -0.11%     
   + Complexity     9121     9095      -26     
   ============================================
     Files           961      961              
     Lines         48151    48119      -32     
     Branches       4679     4679              
   ============================================
   - Hits          33448    33375      -73     
   - Misses        12489    12525      +36     
   - Partials       2214     2219       +5     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/hadoop-ozone/pull/1066?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...main/java/org/apache/hadoop/ozone/OzoneConsts.java](https://codecov.io/gh/apache/hadoop-ozone/pull/1066/diff?src=pr&el=tree#diff-aGFkb29wLWhkZHMvY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9oYWRvb3Avb3pvbmUvT3pvbmVDb25zdHMuamF2YQ==) | `84.21% <ø> (ø)` | `1.00 <0.00> (ø)` | |
   | [...apache/hadoop/hdds/utils/db/RocksDBCheckpoint.java](https://codecov.io/gh/apache/hadoop-ozone/pull/1066/diff?src=pr&el=tree#diff-aGFkb29wLWhkZHMvZnJhbWV3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9oYWRvb3AvaGRkcy91dGlscy9kYi9Sb2Nrc0RCQ2hlY2twb2ludC5qYXZh) | `90.90% <ø> (+0.90%)` | `5.00 <0.00> (-3.00)` | :arrow_up: |
   | [...hadoop/hdds/scm/container/SCMContainerManager.java](https://codecov.io/gh/apache/hadoop-ozone/pull/1066/diff?src=pr&el=tree#diff-aGFkb29wLWhkZHMvc2VydmVyLXNjbS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaGFkb29wL2hkZHMvc2NtL2NvbnRhaW5lci9TQ01Db250YWluZXJNYW5hZ2VyLmphdmE=) | `70.81% <0.00%> (+0.33%)` | `34.00 <0.00> (ø)` | |
   | [...ache/hadoop/hdds/scm/pipeline/PipelineManager.java](https://codecov.io/gh/apache/hadoop-ozone/pull/1066/diff?src=pr&el=tree#diff-aGFkb29wLWhkZHMvc2VydmVyLXNjbS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaGFkb29wL2hkZHMvc2NtL3BpcGVsaW5lL1BpcGVsaW5lTWFuYWdlci5qYXZh) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
   | [...hadoop/hdds/scm/pipeline/PipelineStateManager.java](https://codecov.io/gh/apache/hadoop-ozone/pull/1066/diff?src=pr&el=tree#diff-aGFkb29wLWhkZHMvc2VydmVyLXNjbS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaGFkb29wL2hkZHMvc2NtL3BpcGVsaW5lL1BpcGVsaW5lU3RhdGVNYW5hZ2VyLmphdmE=) | `95.74% <ø> (ø)` | `22.00 <0.00> (ø)` | |
   | [...e/hadoop/hdds/scm/pipeline/SCMPipelineManager.java](https://codecov.io/gh/apache/hadoop-ozone/pull/1066/diff?src=pr&el=tree#diff-aGFkb29wLWhkZHMvc2VydmVyLXNjbS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaGFkb29wL2hkZHMvc2NtL3BpcGVsaW5lL1NDTVBpcGVsaW5lTWFuYWdlci5qYXZh) | `92.64% <ø> (ø)` | `68.00 <0.00> (ø)` | |
   | [.../java/org/apache/hadoop/ozone/om/OMConfigKeys.java](https://codecov.io/gh/apache/hadoop-ozone/pull/1066/diff?src=pr&el=tree#diff-aGFkb29wLW96b25lL2NvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaGFkb29wL296b25lL29tL09NQ29uZmlnS2V5cy5qYXZh) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
   | [.../apache/hadoop/ozone/om/OMDBCheckpointServlet.java](https://codecov.io/gh/apache/hadoop-ozone/pull/1066/diff?src=pr&el=tree#diff-aGFkb29wLW96b25lL296b25lLW1hbmFnZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2hhZG9vcC9vem9uZS9vbS9PTURCQ2hlY2twb2ludFNlcnZsZXQuamF2YQ==) | `66.26% <ø> (-4.27%)` | `8.00 <0.00> (-2.00)` | |
   | [...a/org/apache/hadoop/ozone/om/ha/OMNodeDetails.java](https://codecov.io/gh/apache/hadoop-ozone/pull/1066/diff?src=pr&el=tree#diff-aGFkb29wLW96b25lL296b25lLW1hbmFnZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2hhZG9vcC9vem9uZS9vbS9oYS9PTU5vZGVEZXRhaWxzLmphdmE=) | `86.66% <ø> (ø)` | `12.00 <0.00> (ø)` | |
   | [...p/ozone/om/ratis/utils/OzoneManagerRatisUtils.java](https://codecov.io/gh/apache/hadoop-ozone/pull/1066/diff?src=pr&el=tree#diff-aGFkb29wLW96b25lL296b25lLW1hbmFnZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2hhZG9vcC9vem9uZS9vbS9yYXRpcy91dGlscy9Pem9uZU1hbmFnZXJSYXRpc1V0aWxzLmphdmE=) | `67.44% <0.00%> (-19.13%)` | `39.00 <0.00> (ø)` | |
   | ... and [29 more](https://codecov.io/gh/apache/hadoop-ozone/pull/1066/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/hadoop-ozone/pull/1066?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/hadoop-ozone/pull/1066?src=pr&el=footer). Last update [78255dd...1efdc23](https://codecov.io/gh/apache/hadoop-ozone/pull/1066?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org

[GitHub] [hadoop-ozone] xiaoyuyao commented on a change in pull request #1066: HDDS-3770. Improve getPipelines performance

Posted by GitBox <gi...@apache.org>.
xiaoyuyao commented on a change in pull request #1066:
URL: https://github.com/apache/hadoop-ozone/pull/1066#discussion_r443170321



##########
File path: hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/pipeline/PipelineManager.java
##########
@@ -61,8 +61,8 @@ Pipeline createPipeline(ReplicationType type, ReplicationFactor factor,
       ReplicationFactor factor, Pipeline.PipelineState state);
 
   List<Pipeline> getPipelines(ReplicationType type, ReplicationFactor factor,
-      Pipeline.PipelineState state, Collection<DatanodeDetails> excludeDns,
-      Collection<PipelineID> excludePipelines);

Review comment:
       Can we keep the existing one parameter as Collection which allows passing Set here?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org

[GitHub] [hadoop-ozone] runzhiwang commented on pull request #1066: HDDS-3770. Improve getPipelines performance

Posted by GitBox <gi...@apache.org>.
runzhiwang commented on pull request #1066:
URL: https://github.com/apache/hadoop-ozone/pull/1066#issuecomment-647082626


   @xiaoyuyao Thanks for review. I have updated.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org

[GitHub] [hadoop-ozone] xiaoyuyao commented on a change in pull request #1066: HDDS-3770. Improve getPipelines performance

Posted by GitBox <gi...@apache.org>.
xiaoyuyao commented on a change in pull request #1066:
URL: https://github.com/apache/hadoop-ozone/pull/1066#discussion_r443170344



##########
File path: hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/pipeline/PipelineStateManager.java
##########
@@ -81,8 +81,8 @@ Pipeline getPipeline(PipelineID pipelineID) throws PipelineNotFoundException {
   }
 
   List<Pipeline> getPipelines(ReplicationType type, ReplicationFactor factor,
-      PipelineState state, Collection<DatanodeDetails> excludeDns,
-      Collection<PipelineID> excludePipelines) {

Review comment:
       Same as above.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org

[GitHub] [hadoop-ozone] runzhiwang commented on pull request #1066: HDDS-3770. Improve getPipelines performance

Posted by GitBox <gi...@apache.org>.
runzhiwang commented on pull request #1066:
URL: https://github.com/apache/hadoop-ozone/pull/1066#issuecomment-647352838


   @dineshchitlangia Thanks for review.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org

[GitHub] [hadoop-ozone] elek merged pull request #1066: HDDS-3770. Improve getPipelines performance

Posted by GitBox <gi...@apache.org>.
elek merged pull request #1066:
URL: https://github.com/apache/hadoop-ozone/pull/1066


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org

[GitHub] [hadoop-ozone] codecov-commenter edited a comment on pull request #1066: HDDS-3770. Improve getPipelines performance

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #1066:
URL: https://github.com/apache/hadoop-ozone/pull/1066#issuecomment-643062826


   # [Codecov](https://codecov.io/gh/apache/hadoop-ozone/pull/1066?src=pr&el=h1) Report
   > Merging [#1066](https://codecov.io/gh/apache/hadoop-ozone/pull/1066?src=pr&el=desc) into [master](https://codecov.io/gh/apache/hadoop-ozone/commit/563507cf2501286b2b3ed6d9e816ad7d9bcd46f4&el=desc) will **increase** coverage by `0.11%`.
   > The diff coverage is `52.38%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/hadoop-ozone/pull/1066/graphs/tree.svg?width=650&height=150&src=pr&token=5YeeptJMby)](https://codecov.io/gh/apache/hadoop-ozone/pull/1066?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #1066      +/-   ##
   ============================================
   + Coverage     69.38%   69.49%   +0.11%     
   - Complexity     9104     9115      +11     
   ============================================
     Files           961      961              
     Lines         48121    48114       -7     
     Branches       4676     4679       +3     
   ============================================
   + Hits          33387    33437      +50     
   + Misses        12514    12462      -52     
   + Partials       2220     2215       -5     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/hadoop-ozone/pull/1066?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...hadoop/hdds/scm/container/SCMContainerManager.java](https://codecov.io/gh/apache/hadoop-ozone/pull/1066/diff?src=pr&el=tree#diff-aGFkb29wLWhkZHMvc2VydmVyLXNjbS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaGFkb29wL2hkZHMvc2NtL2NvbnRhaW5lci9TQ01Db250YWluZXJNYW5hZ2VyLmphdmE=) | `70.58% <0.00%> (ø)` | `34.00 <0.00> (ø)` | |
   | [...ache/hadoop/hdds/scm/pipeline/PipelineManager.java](https://codecov.io/gh/apache/hadoop-ozone/pull/1066/diff?src=pr&el=tree#diff-aGFkb29wLWhkZHMvc2VydmVyLXNjbS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaGFkb29wL2hkZHMvc2NtL3BpcGVsaW5lL1BpcGVsaW5lTWFuYWdlci5qYXZh) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
   | [...hadoop/hdds/scm/pipeline/PipelineStateManager.java](https://codecov.io/gh/apache/hadoop-ozone/pull/1066/diff?src=pr&el=tree#diff-aGFkb29wLWhkZHMvc2VydmVyLXNjbS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaGFkb29wL2hkZHMvc2NtL3BpcGVsaW5lL1BpcGVsaW5lU3RhdGVNYW5hZ2VyLmphdmE=) | `95.74% <ø> (ø)` | `22.00 <0.00> (ø)` | |
   | [...e/hadoop/hdds/scm/pipeline/SCMPipelineManager.java](https://codecov.io/gh/apache/hadoop-ozone/pull/1066/diff?src=pr&el=tree#diff-aGFkb29wLWhkZHMvc2VydmVyLXNjbS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaGFkb29wL2hkZHMvc2NtL3BpcGVsaW5lL1NDTVBpcGVsaW5lTWFuYWdlci5qYXZh) | `92.64% <ø> (ø)` | `68.00 <0.00> (ø)` | |
   | [...che/hadoop/hdds/scm/pipeline/PipelineStateMap.java](https://codecov.io/gh/apache/hadoop-ozone/pull/1066/diff?src=pr&el=tree#diff-aGFkb29wLWhkZHMvc2VydmVyLXNjbS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaGFkb29wL2hkZHMvc2NtL3BpcGVsaW5lL1BpcGVsaW5lU3RhdGVNYXAuamF2YQ==) | `83.83% <38.46%> (-3.31%)` | `42.00 <0.00> (-6.00)` | |
   | [...hdds/scm/container/common/helpers/ExcludeList.java](https://codecov.io/gh/apache/hadoop-ozone/pull/1066/diff?src=pr&el=tree#diff-aGFkb29wLWhkZHMvY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9oYWRvb3AvaGRkcy9zY20vY29udGFpbmVyL2NvbW1vbi9oZWxwZXJzL0V4Y2x1ZGVMaXN0LmphdmE=) | `100.00% <100.00%> (+4.08%)` | `22.00 <3.00> (-1.00)` | :arrow_up: |
   | [...apache/hadoop/hdds/scm/block/BlockManagerImpl.java](https://codecov.io/gh/apache/hadoop-ozone/pull/1066/diff?src=pr&el=tree#diff-aGFkb29wLWhkZHMvc2VydmVyLXNjbS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaGFkb29wL2hkZHMvc2NtL2Jsb2NrL0Jsb2NrTWFuYWdlckltcGwuamF2YQ==) | `66.66% <0.00%> (-5.41%)` | `18.00% <0.00%> (ø%)` | |
   | [...p/ozone/container/keyvalue/helpers/ChunkUtils.java](https://codecov.io/gh/apache/hadoop-ozone/pull/1066/diff?src=pr&el=tree#diff-aGFkb29wLWhkZHMvY29udGFpbmVyLXNlcnZpY2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2hhZG9vcC9vem9uZS9jb250YWluZXIva2V5dmFsdWUvaGVscGVycy9DaHVua1V0aWxzLmphdmE=) | `85.45% <0.00%> (-0.91%)` | `30.00% <0.00%> (-1.00%)` | |
   | [.../ozone/container/common/volume/AbstractFuture.java](https://codecov.io/gh/apache/hadoop-ozone/pull/1066/diff?src=pr&el=tree#diff-aGFkb29wLWhkZHMvY29udGFpbmVyLXNlcnZpY2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2hhZG9vcC9vem9uZS9jb250YWluZXIvY29tbW9uL3ZvbHVtZS9BYnN0cmFjdEZ1dHVyZS5qYXZh) | `29.87% <0.00%> (-0.52%)` | `19.00% <0.00%> (-1.00%)` | |
   | [.../common/states/endpoint/HeartbeatEndpointTask.java](https://codecov.io/gh/apache/hadoop-ozone/pull/1066/diff?src=pr&el=tree#diff-aGFkb29wLWhkZHMvY29udGFpbmVyLXNlcnZpY2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2hhZG9vcC9vem9uZS9jb250YWluZXIvY29tbW9uL3N0YXRlcy9lbmRwb2ludC9IZWFydGJlYXRFbmRwb2ludFRhc2suamF2YQ==) | `71.06% <0.00%> (ø)` | `26.00% <0.00%> (ø%)` | |
   | ... and [16 more](https://codecov.io/gh/apache/hadoop-ozone/pull/1066/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/hadoop-ozone/pull/1066?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/hadoop-ozone/pull/1066?src=pr&el=footer). Last update [563507c...212a789](https://codecov.io/gh/apache/hadoop-ozone/pull/1066?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org

[GitHub] [hadoop-ozone] xiaoyuyao commented on a change in pull request #1066: HDDS-3770. Improve getPipelines performance

Posted by GitBox <gi...@apache.org>.
xiaoyuyao commented on a change in pull request #1066:
URL: https://github.com/apache/hadoop-ozone/pull/1066#discussion_r439691874



##########
File path: hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/container/SCMContainerManager.java
##########
@@ -416,13 +417,12 @@ public void updateDeleteTransactionId(Map<Long, Long> deleteTransactionMap)
    */
   public ContainerInfo getMatchingContainer(final long sizeRequired,
       String owner, Pipeline pipeline) {
-    return getMatchingContainer(sizeRequired, owner, pipeline, Collections
-        .emptyList());
+    return getMatchingContainer(sizeRequired, owner, pipeline, new HashSet<>());

Review comment:
       Collections.emptySet() to avoid unnecessary allocation




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org

[GitHub] [hadoop-ozone] elek commented on pull request #1066: HDDS-3770. Improve getPipelines performance

Posted by GitBox <gi...@apache.org>.
elek commented on pull request #1066:
URL: https://github.com/apache/hadoop-ozone/pull/1066#issuecomment-651674170


   Merging this as it has green build + comments from @xiaoyuyao addressed and @dineshchitlangia also approved it. (thanks the reviews).
   
   Thanks the contribution @runzhiwang


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org

[GitHub] [hadoop-ozone] xiaoyuyao commented on a change in pull request #1066: HDDS-3770. Improve getPipelines performance

Posted by GitBox <gi...@apache.org>.
xiaoyuyao commented on a change in pull request #1066:
URL: https://github.com/apache/hadoop-ozone/pull/1066#discussion_r443170256



##########
File path: hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/container/ContainerManager.java
##########
@@ -180,7 +180,7 @@ ContainerInfo getMatchingContainer(long size, String owner,
    * @return ContainerInfo for the matching container.
    */
   ContainerInfo getMatchingContainer(long size, String owner,
-      Pipeline pipeline, List<ContainerID> excludedContainerIDS);
+      Pipeline pipeline, Set<ContainerID> excludedContainerIDS);

Review comment:
       Can we change here to Collection<ContainerID> to make the interface neutral to implementation? The underlying can be List or Set.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org