You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2022/03/18 09:59:59 UTC

[GitHub] [beam] damccorm commented on pull request #17045: [BEAM-10976] Bundle finalization: E2E support

damccorm commented on pull request #17045:
URL: https://github.com/apache/beam/pull/17045#issuecomment-1072254804


   > do you know why there is a large drop in code coverage diff?
   
   @aaltay I think its because out of 306 non-test lines changed, 188 are generated file changes. In particular, `reflectx/calls.go` is going from 0% coverage to 0% coverage, but its contributing 164 new untested lines. So unless I manually test the generated files (and I'd argue we should be testing the generation logic instead), the diff is guaranteed to drop. Looking at the per-file diff, I don't feel particularly bad about any of the changes.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org