You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Vinod Kone <vi...@gmail.com> on 2014/03/04 09:36:05 UTC
Re: Review Request 18676: Added a verify-reviews.py script that can run via
CI to verify Review Board reviews.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18676/
-----------------------------------------------------------
(Updated March 4, 2014, 8:36 a.m.)
Review request for mesos, Benjamin Hindman and Ben Mahler.
Changes
-------
benh's and dominic's.
also, changed the semantics to skip reviews that block others instead of reviews that depends on others.
Summary (updated)
-----------------
Added a verify-reviews.py script that can run via CI to verify Review Board reviews.
Bugs: MESOS-1052
https://issues.apache.org/jira/browse/MESOS-1052
Repository: mesos-git
Description
-------
Created a RB account for the ReviewBot so that it can post reviews.
Diffs (updated)
-----
support/verify-reviews.py PRE-CREATION
Diff: https://reviews.apache.org/r/18676/diff/
Testing
-------
Verified (:)) by slightly modifying the script and testing on the following review.
https://reviews.apache.org/r/18674/
Thanks,
Vinod Kone
Re: Review Request 18676: Added a verify-reviews.py script that can run via
CI to verify Review Board reviews.
Posted by Mesos ReviewBot <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18676/#review36156
-----------------------------------------------------------
Bad patch!
Reviews applied: []
Failed command: git apply --index 18676.patch
Error:
error: support/verify-reviews.py: already exists in index
- Mesos ReviewBot
On March 4, 2014, 6 p.m., Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18676/
> -----------------------------------------------------------
>
> (Updated March 4, 2014, 6 p.m.)
>
>
> Review request for mesos, Benjamin Hindman and Ben Mahler.
>
>
> Bugs: MESOS-1052
> https://issues.apache.org/jira/browse/MESOS-1052
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Created a RB account for the ReviewBot so that it can post reviews.
>
>
> Diffs
> -----
>
> support/verify-reviews.py PRE-CREATION
>
> Diff: https://reviews.apache.org/r/18676/diff/
>
>
> Testing
> -------
>
> Verified (:)) by slightly modifying the script and testing on the following review.
>
> https://reviews.apache.org/r/18674/
>
>
> Thanks,
>
> Vinod Kone
>
>
Re: Review Request 18676: Added a verify-reviews.py script that can run via
CI to verify Review Board reviews.
Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18676/#review36131
-----------------------------------------------------------
support/verify-reviews.py
<https://reviews.apache.org/r/18676/#comment67053>
Sweet PEP 8 my friend.
support/verify-reviews.py
<https://reviews.apache.org/r/18676/#comment67055>
How about 'atexit' delete the patch?
- Benjamin Hindman
On March 4, 2014, 6 p.m., Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18676/
> -----------------------------------------------------------
>
> (Updated March 4, 2014, 6 p.m.)
>
>
> Review request for mesos, Benjamin Hindman and Ben Mahler.
>
>
> Bugs: MESOS-1052
> https://issues.apache.org/jira/browse/MESOS-1052
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Created a RB account for the ReviewBot so that it can post reviews.
>
>
> Diffs
> -----
>
> support/verify-reviews.py PRE-CREATION
>
> Diff: https://reviews.apache.org/r/18676/diff/
>
>
> Testing
> -------
>
> Verified (:)) by slightly modifying the script and testing on the following review.
>
> https://reviews.apache.org/r/18674/
>
>
> Thanks,
>
> Vinod Kone
>
>
Re: Review Request 18676: Added a verify-reviews.py script that can run via
CI to verify Review Board reviews.
Posted by Dominic Hamon <dh...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18676/#review36158
-----------------------------------------------------------
Ship it!
Ship It!
- Dominic Hamon
On March 4, 2014, 12:20 p.m., Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18676/
> -----------------------------------------------------------
>
> (Updated March 4, 2014, 12:20 p.m.)
>
>
> Review request for mesos, Benjamin Hindman and Ben Mahler.
>
>
> Bugs: MESOS-1052
> https://issues.apache.org/jira/browse/MESOS-1052
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Created a RB account for the ReviewBot so that it can post reviews.
>
>
> Diffs
> -----
>
> support/verify-reviews.py PRE-CREATION
>
> Diff: https://reviews.apache.org/r/18676/diff/
>
>
> Testing
> -------
>
> Verified (:)) by slightly modifying the script and testing on the following review.
>
> https://reviews.apache.org/r/18674/
>
>
> Thanks,
>
> Vinod Kone
>
>
Re: Review Request 18676: Added a verify-reviews.py script that can run via
CI to verify Review Board reviews.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18676/
-----------------------------------------------------------
(Updated March 4, 2014, 8:20 p.m.)
Review request for mesos, Benjamin Hindman and Ben Mahler.
Changes
-------
benh's comments. also addressed the multiple dependents issue. PTAL.
Bugs: MESOS-1052
https://issues.apache.org/jira/browse/MESOS-1052
Repository: mesos-git
Description
-------
Created a RB account for the ReviewBot so that it can post reviews.
Diffs (updated)
-----
support/verify-reviews.py PRE-CREATION
Diff: https://reviews.apache.org/r/18676/diff/
Testing
-------
Verified (:)) by slightly modifying the script and testing on the following review.
https://reviews.apache.org/r/18674/
Thanks,
Vinod Kone
Re: Review Request 18676: Added a verify-reviews.py script that can run via
CI to verify Review Board reviews.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18676/
-----------------------------------------------------------
(Updated March 4, 2014, 6 p.m.)
Review request for mesos, Benjamin Hindman and Ben Mahler.
Changes
-------
made the query params also configurable via command line to selectively turn this on specific reviews as we test this feature.
Bugs: MESOS-1052
https://issues.apache.org/jira/browse/MESOS-1052
Repository: mesos-git
Description
-------
Created a RB account for the ReviewBot so that it can post reviews.
Diffs (updated)
-----
support/verify-reviews.py PRE-CREATION
Diff: https://reviews.apache.org/r/18676/diff/
Testing
-------
Verified (:)) by slightly modifying the script and testing on the following review.
https://reviews.apache.org/r/18674/
Thanks,
Vinod Kone