You are viewing a plain text version of this content. The canonical link for it is here.
Posted to codereview@trafodion.apache.org by sureshsubbiah <gi...@git.apache.org> on 2015/11/21 03:06:14 UTC
[GitHub] incubator-trafodion pull request: [TRAFODION-1634] Update stats on...
GitHub user sureshsubbiah opened a pull request:
https://github.com/apache/incubator-trafodion/pull/184
[TRAFODION-1634] Update stats on Hive tables is slow
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/sureshsubbiah/incubator-trafodion ustat1
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-trafodion/pull/184.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #184
----
commit 11c61dc0d325494cb435f37d4f05802ee2def9ee
Author: Suresh Subbiah <su...@apache.org>
Date: 2015-11-21T01:55:00Z
[TRAFODION-1634] Update stats on Hive tables is slow
Fix suggested by Feng Qiang (Vito). Update stats for Hive table uses
INSERT to populate the sample table. It has now been changed to use
UPSERT USING LOAD.
There is also some cleanup change to remove code related to dp2sampling
and the adjustment it required when table had varchar columns.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafodion pull request: [TRAFODION-1634] Update stats on...
Posted by DaveBirdsall <gi...@git.apache.org>.
Github user DaveBirdsall commented on a diff in the pull request:
https://github.com/apache/incubator-trafodion/pull/184#discussion_r45653714
--- Diff: core/sql/ustat/hs_globals.cpp ---
@@ -3857,7 +3759,8 @@ Lng32 HSSample::make(NABoolean rowCountIsEstimate, // input
// need to use a vanilla INSERT statement. Otherwise, we can use SIDETREE
// INSERTS for better performance. A current bug in the HBase interface
// requires the use of Upsert.
- if (hs_globals->isHbaseTable)
+ // For Hive tables the sample table used is a Trafodion table
+ if (hs_globals->isHbaseTable || hs_globals->isHiveTable)
--- End diff --
I gather that fixing the Hive stats performance problem is a one-line fix (just this line) and everything else in this change set pertains to removing obsolete DP2 sampling code?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafodion pull request: [TRAFODION-1634] Update stats on...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-trafodion/pull/184
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---