You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/02/28 05:48:24 UTC
[GitHub] [incubator-nuttx] Donny9 opened a new pull request #5635: fs/romfs: optimize romfs_open speed and get path by cmd FIOC_FILEPATH
Donny9 opened a new pull request #5635:
URL: https://github.com/apache/incubator-nuttx/pull/5635
## Summary
1. Cache all file node info to ram when file system is mounted, then it can avoid emmc/mmcsd access to improve access speed when using romfs_open/romfs_opendir/romfs_readdir.
2. Save file path for every open file, then we can get file path by ioctl with FIOC_FILEPATH.
## Impact
1. Improve romfs access speed when enable CONFIG_FS_ROMFS_CACHE_NODE.
2. When enable CONFIG_FS_ROMFS_CACHE_NODE, the cache operation consumes at least 20bytes for each file.
3. look file path for every fd when cat /proc/pid/group/fd.
## Testing
N/A
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] acassis commented on a change in pull request #5635: fs/romfs: optimize romfs_open speed and get path by cmd FIOC_FILEPATH
Posted by GitBox <gi...@apache.org>.
acassis commented on a change in pull request #5635:
URL: https://github.com/apache/incubator-nuttx/pull/5635#discussion_r815865145
##########
File path: fs/romfs/Kconfig
##########
@@ -11,4 +11,13 @@ config FS_ROMFS
Enable ROMFS filesystem support
if FS_ROMFS
+
+config FS_ROMFS_CACHE_NODE
+ bool "Enable cache node of ROMFS file system"
+ default n
Review comment:
Maybe it could be default y if !CONFIG_DEFAULT_SMALL. I think if a feature brings benefit to users (like speed/performance) it could be enabled by default. Otherwise we are creating many useful features that many people don't know that exist (he/she will need to search high and low the menuconfig to discover it).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #5635: fs/romfs: optimize romfs_open speed and get path by cmd FIOC_FILEPATH
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #5635:
URL: https://github.com/apache/incubator-nuttx/pull/5635#discussion_r815922004
##########
File path: fs/romfs/Kconfig
##########
@@ -11,4 +11,14 @@ config FS_ROMFS
Enable ROMFS filesystem support
if FS_ROMFS
+
+config FS_ROMFS_CACHE_NODE
+ bool "Enable cache node of ROMFS file system"
+ default n if DEFAULT_SMALL
+ default y if !DEFAULT_SMALL
Review comment:
change to:
default !DEFAULT_SMALL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] Donny9 commented on a change in pull request #5635: fs/romfs: optimize romfs_open speed and get path by cmd FIOC_FILEPATH
Posted by GitBox <gi...@apache.org>.
Donny9 commented on a change in pull request #5635:
URL: https://github.com/apache/incubator-nuttx/pull/5635#discussion_r815908158
##########
File path: fs/romfs/Kconfig
##########
@@ -11,4 +11,13 @@ config FS_ROMFS
Enable ROMFS filesystem support
if FS_ROMFS
+
+config FS_ROMFS_CACHE_NODE
+ bool "Enable cache node of ROMFS file system"
+ default n
Review comment:
Done!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] acassis commented on a change in pull request #5635: fs/romfs: optimize romfs_open speed and get path by cmd FIOC_FILEPATH
Posted by GitBox <gi...@apache.org>.
acassis commented on a change in pull request #5635:
URL: https://github.com/apache/incubator-nuttx/pull/5635#discussion_r815865145
##########
File path: fs/romfs/Kconfig
##########
@@ -11,4 +11,13 @@ config FS_ROMFS
Enable ROMFS filesystem support
if FS_ROMFS
+
+config FS_ROMFS_CACHE_NODE
+ bool "Enable cache node of ROMFS file system"
+ default n
Review comment:
Maybe it could be default y if !CONFIG_DEFAULT_SMALL. I think if a feature that brings benefit to users (like speed/performance) it could be enabled by default. Otherwise we are creating many useful features that many people don't know that exist (he/she will need to search high and low the menuconfig to discover it).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #5635: fs/romfs: optimize romfs_open speed and get path by cmd FIOC_FILEPATH
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 merged pull request #5635:
URL: https://github.com/apache/incubator-nuttx/pull/5635
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org