[GitHub] [flink] nateab commented on a diff in pull request #22313: [FLINK-31660][connector-kafka] fix kafka connector pom so ITCases run in IDE

["nateab (via GitHub)" <gi...@apache.org>]

nateab commented on code in PR #22313:
URL: https://github.com/apache/flink/pull/22313#discussion_r1159018047


##########
flink-connectors/flink-connector-kafka/pom.xml:
##########
@@ -225,6 +241,23 @@ under the License.
 
 	<build>
 		<plugins>
+			<plugin>
+				<groupId>org.apache.maven.plugins</groupId>
+				<artifactId>maven-enforcer-plugin</artifactId>
+				<executions>
+					<execution>
+						<id>forbid-direct-table-planner-dependencies</id>
+						<goals>
+							<goal>enforce</goal>
+						</goals>
+						<configuration>
+							<!-- We need to depend on table planner because we rely on its internals -->

Review Comment:
   for this and the below pom changes, we based it off a similar module `flink-connector-hive` that had working `TableITCase`s. However, Chesnay suggested a cleaner solution, so i will follow through with that instead



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org