[GitHub] [incubator-druid] jihoonson commented on a change in pull request #9036: benchmark schema with numeric dimensions and null column values

[GitBox <gi...@apache.org>]

jihoonson commented on a change in pull request #9036: benchmark schema with numeric dimensions and null column values
URL: https://github.com/apache/incubator-druid/pull/9036#discussion_r359097218
 
 

 ##########
 File path: benchmarks/src/main/java/org/apache/druid/benchmark/datagen/BenchmarkSchemas.java
 ##########
 @@ -225,4 +225,32 @@
     );
     SCHEMA_MAP.put("rollo", rolloSchema);
   }
+
+  static { // simple schema with null valued rows, no aggs on numeric columns
+    List<BenchmarkColumnSchema> simpleNullsSchemaColumns = ImmutableList.of(
+        // dims
+        BenchmarkColumnSchema.makeZipf("stringZipf", ValueType.STRING, false, 1, 0.5, 1, 101, 1.5),
+        BenchmarkColumnSchema.makeDiscreteUniform("stringUniform", ValueType.STRING, false, 1, 0.25, 1, 100000),
+        BenchmarkColumnSchema.makeSequential("stringSequentialHalfNull", ValueType.STRING, false, 1, 0.5, 0, 1000),
+
+        // metrics
 
 Review comment:
   Looks like they are not metrics?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org