You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@logging.apache.org by ck...@apache.org on 2022/01/18 01:40:05 UTC

[logging-log4j2] 02/02: Additional log4j-to-jul test coverage for correct formatting (#712)

This is an automated email from the ASF dual-hosted git repository.

ckozak pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/logging-log4j2.git

commit d425819cb51699deb2dfbb21c3bbb5bda6962cc4
Author: Carter Kozak <ck...@apache.org>
AuthorDate: Mon Jan 17 20:38:24 2022 -0500

    Additional log4j-to-jul test coverage for correct formatting (#712)
    
    These tests provide additional coverage in the event parameters
    are passed through, demonstrating how JUL formatters are likely
    to misinterpret such LogRecords.
---
 .../org/apache/logging/log4j/tojul/LoggerTest.java | 22 ++++++++++++++++++++++
 1 file changed, 22 insertions(+)

diff --git a/log4j-to-jul/src/test/java/org/apache/logging/log4j/tojul/LoggerTest.java b/log4j-to-jul/src/test/java/org/apache/logging/log4j/tojul/LoggerTest.java
index 8060fea..ae6325f 100644
--- a/log4j-to-jul/src/test/java/org/apache/logging/log4j/tojul/LoggerTest.java
+++ b/log4j-to-jul/src/test/java/org/apache/logging/log4j/tojul/LoggerTest.java
@@ -237,4 +237,26 @@ public class LoggerTest {
             anotherLog4jLogger.info("hello, another world");
         }
     }
+
+    @Test public void placeholdersInFormat() {
+        julLogger.setLevel(Level.INFO);
+        log4jLogger.info("hello, {0} {}", "world");
+
+        List<LogRecord> logs = handler.getStoredLogRecords();
+        assertThat(logs).hasSize(1);
+        LogRecord log1 = logs.get(0);
+        String formattedMessage = new java.util.logging.SimpleFormatter().formatMessage(log1);
+        assertThat(formattedMessage).isEqualTo("hello, {0} world");
+    }
+
+    @Test public void placeholdersInFormattedMessage() {
+        julLogger.setLevel(Level.INFO);
+        log4jLogger.info("hello, {}", "{0} world");
+
+        List<LogRecord> logs = handler.getStoredLogRecords();
+        assertThat(logs).hasSize(1);
+        LogRecord log1 = logs.get(0);
+        String formattedMessage = new java.util.logging.SimpleFormatter().formatMessage(log1);
+        assertThat(formattedMessage).isEqualTo("hello, {0} world");
+    }
 }