You are viewing a plain text version of this content. The canonical link for it is here.
Posted to cvs@cocoon.apache.org by jb...@apache.org on 2006/01/16 17:15:00 UTC

svn commit: r369507 - in /cocoon: branches/BRANCH_2_1_X/status.xml trunk/cocoon-forms/cocoon-forms-impl/src/main/java/org/apache/cocoon/forms/binding/ValueJXPathBinding.java

Author: jbq
Date: Mon Jan 16 08:14:54 2006
New Revision: 369507

URL: http://svn.apache.org/viewcvs?rev=369507&view=rev
Log:
Fix COCOON-1687: When saving a cform, remove xml elements if the value of the widget is null
Symptom is eg date field initialized to 1970-01-01

Patched by Philippe Gassmann <ph...@anyware-tech.com>

Modified:
    cocoon/branches/BRANCH_2_1_X/status.xml
    cocoon/trunk/cocoon-forms/cocoon-forms-impl/src/main/java/org/apache/cocoon/forms/binding/ValueJXPathBinding.java

Modified: cocoon/branches/BRANCH_2_1_X/status.xml
URL: http://svn.apache.org/viewcvs/cocoon/branches/BRANCH_2_1_X/status.xml?rev=369507&r1=369506&r2=369507&view=diff
==============================================================================
--- cocoon/branches/BRANCH_2_1_X/status.xml (original)
+++ cocoon/branches/BRANCH_2_1_X/status.xml Mon Jan 16 08:14:54 2006
@@ -180,6 +180,10 @@
   <release version="@version@" date="@date@">
 -->
   <release version="2.1.9" date="TBD">
+    <action dev="JBQ" type="fix" fixes-bug="COCOON-1687" due-to="Philippe Gassmann" due-to-email="phil@anyware-tech.com">
+      When saving a cform, remove xml elements if the value of the widget is null.
+      Symptom is eg date field initialized to 1970-01-01
+    </action>
     <action dev="JBQ" type="fix" fixes-bug="COCOON-1259">
       XMLDBTransformer can use username/password to access XMLDB.
       Note that DatabaseManager.getCollection() accepts null values for user and

Modified: cocoon/trunk/cocoon-forms/cocoon-forms-impl/src/main/java/org/apache/cocoon/forms/binding/ValueJXPathBinding.java
URL: http://svn.apache.org/viewcvs/cocoon/trunk/cocoon-forms/cocoon-forms-impl/src/main/java/org/apache/cocoon/forms/binding/ValueJXPathBinding.java?rev=369507&r1=369506&r2=369507&view=diff
==============================================================================
--- cocoon/trunk/cocoon-forms/cocoon-forms-impl/src/main/java/org/apache/cocoon/forms/binding/ValueJXPathBinding.java (original)
+++ cocoon/trunk/cocoon-forms/cocoon-forms-impl/src/main/java/org/apache/cocoon/forms/binding/ValueJXPathBinding.java Mon Jan 16 08:14:54 2006
@@ -129,7 +129,11 @@
 
         if ((value == null && oldValue != null) || value != null && !value.equals(oldValue)) {
             // first update the value itself
-            jxpc.createPathAndSetValue(this.xpath, value);
+            if(value != null) {
+                jxpc.createPathAndSetValue(this.xpath, value);
+            } else {
+                jxpc.removePath(this.xpath);
+            }
 
             // now perform any other bindings that need to be performed when the value is updated
             JXPathContext subContext = null;