You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2021/11/04 09:21:03 UTC
[GitHub] [camel] oscerd commented on a change in pull request #5787: Fixes based on the run of the static analysis tool Findbugs
oscerd commented on a change in pull request #5787:
URL: https://github.com/apache/camel/pull/5787#discussion_r742657378
##########
File path: core/camel-xml-jaxp/src/main/java/org/apache/camel/converter/jaxp/StaxConverter.java
##########
@@ -316,7 +319,10 @@ private XMLOutputFactory getXMLOutputFactory() {
private void returnXMLOutputFactory(XMLOutputFactory factory) {
if (factory != outputFactory) {
- OUTPUT_FACTORY_POOL.offer(factory);
+ boolean resultOfOffer = OUTPUT_FACTORY_POOL.offer(factory);
+ if (!resultOfOffer) {
+ LOG.error("factory wasn't added into OUTPUT_FACTORY_POOL");
Review comment:
We should trust static analysis tool
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org