You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@storm.apache.org by leedohyun <gi...@git.apache.org> on 2016/08/17 08:04:25 UTC

[GitHub] storm pull request #1629: Fix code in KafkaSpoutRetryExponentialBackoff.java

GitHub user leedohyun opened a pull request:

    https://github.com/apache/storm/pull/1629

    Fix code in KafkaSpoutRetryExponentialBackoff.java

    Additionally, Is there some reasons for use as below in README.md.
    `
    new KafkaSpoutRetryExponentialBackoff.TimeInterval(500, TimeUnit.MICROSECONDS)
    `
    
    I think this is better.
    `
    KafkaSpoutRetryExponentialBackoff.TimeInterval.microSeconds(500)
    `

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/leedohyun/storm master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/storm/pull/1629.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1629
    
----
commit d1f372cc249e600c779438ea5025844d2d8756a2
Author: leedohyun <le...@gmail.com>
Date:   2016-08-17T06:51:51Z

    fix wrong code

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] storm issue #1629: Fix code in KafkaSpoutRetryExponentialBackoff.java

Posted by leedohyun <gi...@git.apache.org>.

Github user leedohyun commented on the issue:

    https://github.com/apache/storm/pull/1629
  
    @HeartSaVioR 
    Thank you for your review!!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] storm issue #1629: Fix code in KafkaSpoutRetryExponentialBackoff.java

Posted by HeartSaVioR <gi...@git.apache.org>.

Github user HeartSaVioR commented on the issue:

    https://github.com/apache/storm/pull/1629
  
    Merged into master, 1.x, 1.0.x branches respectively.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] storm issue #1629: Fix code in KafkaSpoutRetryExponentialBackoff.java

Posted by HeartSaVioR <gi...@git.apache.org>.

Github user HeartSaVioR commented on the issue:

    https://github.com/apache/storm/pull/1629
  
    @leedohyun 
    +1 for the change, and yes I also think it would be better to change like you stated since other parameters already use that method.
    Could you also change that thing? Thanks in advance.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] storm issue #1629: Fix code in KafkaSpoutRetryExponentialBackoff.java

Posted by HeartSaVioR <gi...@git.apache.org>.

Github user HeartSaVioR commented on the issue:

    https://github.com/apache/storm/pull/1629
  
    +1 Thanks for the work @leedohyun 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] storm pull request #1629: Fix code in KafkaSpoutRetryExponentialBackoff.java

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/storm/pull/1629


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---