You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Qifan Chen (Code Review)" <ge...@cloudera.org> on 2021/09/22 17:10:17 UTC

[Impala-ASF-CR] IMPALA-10927 TestFetchAndSpooling.test rows sent counters is flaky in core-s3 based test 

Qifan Chen has uploaded this change for review. ( http://gerrit.cloudera.org:8080/17862


Change subject: IMPALA-10927 TestFetchAndSpooling.test_rows_sent_counters is flaky in core-s3 based test
......................................................................

IMPALA-10927 TestFetchAndSpooling.test_rows_sent_counters is flaky in core-s3 based test

This fix removes the flakiness for test_rows_sent_counters test by disabling
it in S3 testing environment.

Testing:
1. Unit test in a non-S3 environment.

Change-Id: Ie6f1a8bc80c24c1368282be097aa8f943dd95d1e
---
M tests/query_test/test_fetch.py
1 file changed, 3 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/62/17862/2
-- 
To view, visit http://gerrit.cloudera.org:8080/17862
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie6f1a8bc80c24c1368282be097aa8f943dd95d1e
Gerrit-Change-Number: 17862
Gerrit-PatchSet: 2
Gerrit-Owner: Qifan Chen <qc...@cloudera.com>

[Impala-ASF-CR] IMPALA-10927 TestFetchAndSpooling.test rows sent counters is flaky in core-s3 based test

Posted by "Qifan Chen (Code Review)" <ge...@cloudera.org>.
Qifan Chen has uploaded a new patch set (#4). ( http://gerrit.cloudera.org:8080/17862 )

Change subject: IMPALA-10927 TestFetchAndSpooling.test_rows_sent_counters is flaky in core-s3 based test
......................................................................

IMPALA-10927 TestFetchAndSpooling.test_rows_sent_counters is flaky in core-s3 based test

This fix removes the flakiness for test_rows_sent_counters test by
disabling it in S3 testing environment.

Testing:
1. Unit test in a non-S3 environment.

Change-Id: Ie6f1a8bc80c24c1368282be097aa8f943dd95d1e
---
M tests/query_test/test_fetch.py
1 file changed, 2 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/62/17862/4
-- 
To view, visit http://gerrit.cloudera.org:8080/17862
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ie6f1a8bc80c24c1368282be097aa8f943dd95d1e
Gerrit-Change-Number: 17862
Gerrit-PatchSet: 4
Gerrit-Owner: Qifan Chen <qc...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>

[Impala-ASF-CR] IMPALA-10927 TestFetchAndSpooling.test rows sent counters is flaky in core-s3 based test

Posted by "Qifan Chen (Code Review)" <ge...@cloudera.org>.
Qifan Chen has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/17862 )

Change subject: IMPALA-10927 TestFetchAndSpooling.test_rows_sent_counters is flaky in core-s3 based test
......................................................................

IMPALA-10927 TestFetchAndSpooling.test_rows_sent_counters is flaky in core-s3 based test

This fix removes the flakiness for test_rows_sent_counters test by
disabling it in S3 testing environment.

Testing:
1. Unit test in a non-S3 environment;
2. Ran core test successfully.

Change-Id: Ie6f1a8bc80c24c1368282be097aa8f943dd95d1e
Reviewed-on: http://gerrit.cloudera.org:8080/17862
Reviewed-by: Wenzhe Zhou <wz...@cloudera.com>
Tested-by: Qifan Chen <qc...@cloudera.com>
---
M tests/query_test/test_fetch.py
1 file changed, 2 insertions(+), 0 deletions(-)

Approvals:
  Wenzhe Zhou: Looks good to me, approved
  Qifan Chen: Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/17862
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie6f1a8bc80c24c1368282be097aa8f943dd95d1e
Gerrit-Change-Number: 17862
Gerrit-PatchSet: 6
Gerrit-Owner: Qifan Chen <qc...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Qifan Chen <qc...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>

[Impala-ASF-CR] IMPALA-10927 TestFetchAndSpooling.test rows sent counters is flaky in core-s3 based test

Posted by "Wenzhe Zhou (Code Review)" <ge...@cloudera.org>.
Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/17862 )

Change subject: IMPALA-10927 TestFetchAndSpooling.test_rows_sent_counters is flaky in core-s3 based test
......................................................................


Patch Set 5: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/17862
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie6f1a8bc80c24c1368282be097aa8f943dd95d1e
Gerrit-Change-Number: 17862
Gerrit-PatchSet: 5
Gerrit-Owner: Qifan Chen <qc...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Tue, 28 Sep 2021 16:34:28 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-10927 TestFetchAndSpooling.test rows sent counters is flaky in core-s3 based test

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17862 )

Change subject: IMPALA-10927 TestFetchAndSpooling.test_rows_sent_counters is flaky in core-s3 based test
......................................................................


Patch Set 3:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/9484/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/17862
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie6f1a8bc80c24c1368282be097aa8f943dd95d1e
Gerrit-Change-Number: 17862
Gerrit-PatchSet: 3
Gerrit-Owner: Qifan Chen <qc...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 22 Sep 2021 17:33:44 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-10927 TestFetchAndSpooling.test rows sent counters is flaky in core-s3 based test

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17862 )

Change subject: IMPALA-10927 TestFetchAndSpooling.test_rows_sent_counters is flaky in core-s3 based test
......................................................................


Patch Set 3:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/17862/3/tests/query_test/test_fetch.py
File tests/query_test/test_fetch.py:

http://gerrit.cloudera.org:8080/#/c/17862/3/tests/query_test/test_fetch.py@24
PS3, Line 24: from tests.util.filesystem_utils import IS_S3
flake8: F401 'tests.util.filesystem_utils.IS_S3' imported but unused



-- 
To view, visit http://gerrit.cloudera.org:8080/17862
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie6f1a8bc80c24c1368282be097aa8f943dd95d1e
Gerrit-Change-Number: 17862
Gerrit-PatchSet: 3
Gerrit-Owner: Qifan Chen <qc...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 22 Sep 2021 17:12:01 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-10927 TestFetchAndSpooling.test rows sent counters is flaky in core-s3 based test

Posted by "Wenzhe Zhou (Code Review)" <ge...@cloudera.org>.
Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/17862 )

Change subject: IMPALA-10927 TestFetchAndSpooling.test_rows_sent_counters is flaky in core-s3 based test
......................................................................


Patch Set 4: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/17862
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie6f1a8bc80c24c1368282be097aa8f943dd95d1e
Gerrit-Change-Number: 17862
Gerrit-PatchSet: 4
Gerrit-Owner: Qifan Chen <qc...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Thu, 23 Sep 2021 21:00:06 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-10927 TestFetchAndSpooling.test rows sent counters is flaky in core-s3 based test

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17862 )

Change subject: IMPALA-10927 TestFetchAndSpooling.test_rows_sent_counters is flaky in core-s3 based test
......................................................................


Patch Set 4:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/9487/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/17862
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie6f1a8bc80c24c1368282be097aa8f943dd95d1e
Gerrit-Change-Number: 17862
Gerrit-PatchSet: 4
Gerrit-Owner: Qifan Chen <qc...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 22 Sep 2021 18:43:06 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-10927 TestFetchAndSpooling.test rows sent counters is flaky in core-s3 based test

Posted by "Qifan Chen (Code Review)" <ge...@cloudera.org>.
Qifan Chen has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/17862 )

Change subject: IMPALA-10927 TestFetchAndSpooling.test_rows_sent_counters is flaky in core-s3 based test
......................................................................

IMPALA-10927 TestFetchAndSpooling.test_rows_sent_counters is flaky in core-s3 based test

This fix removes the flakiness for test_rows_sent_counters test by
disabling it in S3 testing environment.

Testing:
1. Unit test in a non-S3 environment.

Change-Id: Ie6f1a8bc80c24c1368282be097aa8f943dd95d1e
---
M tests/query_test/test_fetch.py
1 file changed, 3 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/62/17862/3
-- 
To view, visit http://gerrit.cloudera.org:8080/17862
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ie6f1a8bc80c24c1368282be097aa8f943dd95d1e
Gerrit-Change-Number: 17862
Gerrit-PatchSet: 3
Gerrit-Owner: Qifan Chen <qc...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>

[Impala-ASF-CR] IMPALA-10927 TestFetchAndSpooling.test rows sent counters is flaky in core-s3 based test

Posted by "Qifan Chen (Code Review)" <ge...@cloudera.org>.
Qifan Chen has posted comments on this change. ( http://gerrit.cloudera.org:8080/17862 )

Change subject: IMPALA-10927 TestFetchAndSpooling.test_rows_sent_counters is flaky in core-s3 based test
......................................................................


Patch Set 5: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/17862
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie6f1a8bc80c24c1368282be097aa8f943dd95d1e
Gerrit-Change-Number: 17862
Gerrit-PatchSet: 5
Gerrit-Owner: Qifan Chen <qc...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Qifan Chen <qc...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Tue, 28 Sep 2021 16:35:34 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-10927 TestFetchAndSpooling.test rows sent counters is flaky in core-s3 based test

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17862 )

Change subject: IMPALA-10927 TestFetchAndSpooling.test_rows_sent_counters is flaky in core-s3 based test
......................................................................


Patch Set 5:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/9517/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/17862
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie6f1a8bc80c24c1368282be097aa8f943dd95d1e
Gerrit-Change-Number: 17862
Gerrit-PatchSet: 5
Gerrit-Owner: Qifan Chen <qc...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Tue, 28 Sep 2021 13:12:54 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-10927 TestFetchAndSpooling.test rows sent counters is flaky in core-s3 based test

Posted by "Qifan Chen (Code Review)" <ge...@cloudera.org>.
Qifan Chen has uploaded a new patch set (#5). ( http://gerrit.cloudera.org:8080/17862 )

Change subject: IMPALA-10927 TestFetchAndSpooling.test_rows_sent_counters is flaky in core-s3 based test
......................................................................

IMPALA-10927 TestFetchAndSpooling.test_rows_sent_counters is flaky in core-s3 based test

This fix removes the flakiness for test_rows_sent_counters test by
disabling it in S3 testing environment.

Testing:
1. Unit test in a non-S3 environment;
2. Ran core test successfully.

Change-Id: Ie6f1a8bc80c24c1368282be097aa8f943dd95d1e
---
M tests/query_test/test_fetch.py
1 file changed, 2 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/62/17862/5
-- 
To view, visit http://gerrit.cloudera.org:8080/17862
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ie6f1a8bc80c24c1368282be097aa8f943dd95d1e
Gerrit-Change-Number: 17862
Gerrit-PatchSet: 5
Gerrit-Owner: Qifan Chen <qc...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>

[Impala-ASF-CR] IMPALA-10927 TestFetchAndSpooling.test rows sent counters is flaky in core-s3 based test

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17862 )

Change subject: IMPALA-10927 TestFetchAndSpooling.test_rows_sent_counters is flaky in core-s3 based test
......................................................................


Patch Set 2:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/9483/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/17862
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie6f1a8bc80c24c1368282be097aa8f943dd95d1e
Gerrit-Change-Number: 17862
Gerrit-PatchSet: 2
Gerrit-Owner: Qifan Chen <qc...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 22 Sep 2021 17:33:45 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-10927 TestFetchAndSpooling.test rows sent counters is flaky in core-s3 based test

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17862 )

Change subject: IMPALA-10927 TestFetchAndSpooling.test_rows_sent_counters is flaky in core-s3 based test
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/17862/2/tests/query_test/test_fetch.py
File tests/query_test/test_fetch.py:

http://gerrit.cloudera.org:8080/#/c/17862/2/tests/query_test/test_fetch.py@24
PS2, Line 24: from tests.util.filesystem_utils import IS_S3
flake8: F401 'tests.util.filesystem_utils.IS_S3' imported but unused



-- 
To view, visit http://gerrit.cloudera.org:8080/17862
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie6f1a8bc80c24c1368282be097aa8f943dd95d1e
Gerrit-Change-Number: 17862
Gerrit-PatchSet: 2
Gerrit-Owner: Qifan Chen <qc...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 22 Sep 2021 17:11:06 +0000
Gerrit-HasComments: Yes