[jira] [Commented] (BIGTOP-1643) vagrant-puppet to support debian as well

["Evans Ye (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/BIGTOP-1643?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14300075#comment-14300075 ] 

Evans Ye commented on BIGTOP-1643:
----------------------------------

Hey [~oflebbe] thanks for the patch, this is exactly a missing piece we're looking for!
I reviewed the patch and its all good, although I haven't test it yet.
Couple of minor suggestions:
* Since there's already a *-d, --destroy* option, shall we rename *-d,--distro* to *-D, --Distro*?
* Do we have default available debian packages on jenkins? It would be better to have one as default: 
{code}
repo_debian: "http://xxx/repo"
{code}

The image is built from debian:jessie. It's fine to use the official image, but I think for bigtop we should have our own *seed* for debian as well. In that way we can guarantee it works w/o out-of -control updates on the image. This brings up another question that is, is it the time to have *bigtop-images* to store all the Dockerfiles [~rvs]? Users can build bigtop slaves, puppet, ssh from these Dockerfiles by themselves, and we can separate out the build image logic in {{docker-hadoop.sh}}, too. But that's another story. I think its ok to use official image in this patch.

> vagrant-puppet to support debian as well
> ----------------------------------------
>
>                 Key: BIGTOP-1643
>                 URL: https://issues.apache.org/jira/browse/BIGTOP-1643
>             Project: Bigtop
>          Issue Type: Bug
>            Reporter: Olaf Flebbe
>            Assignee: Olaf Flebbe
>         Attachments: 0001-BIGTOP-1643.-vagrant-puppet-docker-to-support-debian.patch, 0001-BIGTOP-1643.-vagrant-puppet-to-support-debian-as-wel.patch
>
>
> Add support for debian in docker-hadoop.sh :
> Now option -d debian 
> (default is -d centos, may not be given)
> to be used like
> ./docker-hadoop.sh -d debian -b
> ./docker-hadoop.sh -d debian -c 3
> There is a puppet problem when creating the hadoop cluster (include stdlib seems not to work correctly).  Will fix it 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)