You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/12/28 07:35:33 UTC
[GitHub] [airflow] stamixthereal opened a new pull request, #28617: Add .bash extension to SSHOperator
stamixthereal opened a new pull request, #28617:
URL: https://github.com/apache/airflow/pull/28617
New `.bash` extension was added to `SSHOperator` into template_ext
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on a diff in pull request #28617: Add .bash extension to SSHOperator
Posted by GitBox <gi...@apache.org>.
potiuk commented on code in PR #28617:
URL: https://github.com/apache/airflow/pull/28617#discussion_r1058300269
##########
airflow/providers/ssh/operators/ssh.py:
##########
@@ -63,7 +63,10 @@ class SSHOperator(BaseOperator):
"""
template_fields: Sequence[str] = ("command", "environment", "remote_host")
- template_ext: Sequence[str] = (".sh",)
+ template_ext: Sequence[str] = (
+ ".sh",
+ ".bash",
Review Comment:
```suggestion
".bash",
".csh",
".zsh",
".dash",
".ksh",
```
Why not?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #28617: Add .bash extension to SSHOperator
Posted by GitBox <gi...@apache.org>.
potiuk merged PR #28617:
URL: https://github.com/apache/airflow/pull/28617
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org