[GitHub] jrthe42 commented on a change in pull request #6666: [FLINK-10290] [table] Fix conversion error in StreamScan and BatchScan

[GitBox <gi...@apache.org>]

jrthe42 commented on a change in pull request #6666: [FLINK-10290] [table] Fix conversion error in StreamScan and BatchScan
URL: https://github.com/apache/flink/pull/6666#discussion_r217662507
 
 

 ##########
 File path: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/datastream/StreamScan.scala
 ##########
 @@ -50,11 +51,12 @@ trait StreamScan extends CommonScan[CRow] with DataStreamRel {
       f == TimeIndicatorTypeInfo.ROWTIME_STREAM_MARKER ||
       f == TimeIndicatorTypeInfo.PROCTIME_STREAM_MARKER)
 
-    if (input.getType == cRowType && !hasTimeIndicator) {
+    if (inputType == cRowType && !hasTimeIndicator) {
 
 Review comment:
   Hi @fhueske, thanks for your review.
   
   I thought about your comment, and I found it's hard to come up with a test case that `inputType` here is of `CRowTypeInfo`.  Since only a datastream of these types (Row, POJO, Tuple, Case class, and Atomic Type) can be registered as a Table, the `inputType` here can never be `CRowTypeInfo`. May be we can remove the If condition here. Correct me if I am wrong.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services