You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/10/28 10:25:33 UTC
[GitHub] [spark] dchvn opened a new pull request #34424: [SPARK-37144][PYTHON] Inline type hints for python/pyspark/file.py
dchvn opened a new pull request #34424:
URL: https://github.com/apache/spark/pull/34424
### What changes were proposed in this pull request?
Inline type hints for python/pyspark/file.py
### Why are the changes needed?
Inline type hints for python/pyspark/file.py
### Does this PR introduce _any_ user-facing change?
No
### How was this patch tested?
exist test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34424: [SPARK-37144][PYTHON] Inline type hints for python/pyspark/file.py
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34424:
URL: https://github.com/apache/spark/pull/34424#issuecomment-953830803
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/49182/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dchvn commented on pull request #34424: [SPARK-37144][PYTHON] Inline type hints for python/pyspark/file.py
Posted by GitBox <gi...@apache.org>.
dchvn commented on pull request #34424:
URL: https://github.com/apache/spark/pull/34424#issuecomment-953925961
CC @HyukjinKwon @zero323 @ueshin FYI. Many thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon closed pull request #34424: [SPARK-37144][PYTHON] Inline type hints for python/pyspark/file.py
Posted by GitBox <gi...@apache.org>.
HyukjinKwon closed pull request #34424:
URL: https://github.com/apache/spark/pull/34424
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34424: [SPARK-37144][PYTHON] Inline type hints for python/pyspark/file.py
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34424:
URL: https://github.com/apache/spark/pull/34424#issuecomment-953738122
**[Test build #144713 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144713/testReport)** for PR 34424 at commit [`1385e67`](https://github.com/apache/spark/commit/1385e6714514ee3ce1b7bf2d0b6a109136fb5b42).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34424: [SPARK-37144][PYTHON] Inline type hints for python/pyspark/file.py
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34424:
URL: https://github.com/apache/spark/pull/34424#issuecomment-953715368
**[Test build #144713 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144713/testReport)** for PR 34424 at commit [`1385e67`](https://github.com/apache/spark/commit/1385e6714514ee3ce1b7bf2d0b6a109136fb5b42).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34424: [SPARK-37144][PYTHON] Inline type hints for python/pyspark/file.py
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34424:
URL: https://github.com/apache/spark/pull/34424#issuecomment-953830803
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/49182/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34424: [SPARK-37144][PYTHON] Inline type hints for python/pyspark/file.py
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34424:
URL: https://github.com/apache/spark/pull/34424#issuecomment-953744679
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/144713/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34424: [SPARK-37144][PYTHON] Inline type hints for python/pyspark/file.py
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34424:
URL: https://github.com/apache/spark/pull/34424#issuecomment-953744679
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/144713/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on a change in pull request #34424: [SPARK-37144][PYTHON] Inline type hints for python/pyspark/file.py
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on a change in pull request #34424:
URL: https://github.com/apache/spark/pull/34424#discussion_r738934580
##########
File path: python/pyspark/files.py
##########
@@ -30,29 +35,32 @@ class SparkFiles(object):
instances.
"""
- _root_directory = None
- _is_running_on_worker = False
- _sc = None
+ _root_directory: ClassVar[Optional[str]] = None
+ _is_running_on_worker: ClassVar[bool] = False
+ _sc: ClassVar[Optional["SparkContext"]] = None
Review comment:
we don't have to type private vars. but I guess mypy complained about the return type? It's fine then.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34424: [SPARK-37144][PYTHON] Inline type hints for python/pyspark/file.py
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34424:
URL: https://github.com/apache/spark/pull/34424#issuecomment-953817290
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/49182/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] zero323 commented on a change in pull request #34424: [SPARK-37144][PYTHON] Inline type hints for python/pyspark/file.py
Posted by GitBox <gi...@apache.org>.
zero323 commented on a change in pull request #34424:
URL: https://github.com/apache/spark/pull/34424#discussion_r738996974
##########
File path: python/pyspark/files.py
##########
@@ -30,29 +35,32 @@ class SparkFiles(object):
instances.
"""
- _root_directory = None
- _is_running_on_worker = False
- _sc = None
+ _root_directory: ClassVar[Optional[str]] = None
+ _is_running_on_worker: ClassVar[bool] = False
+ _sc: ClassVar[Optional["SparkContext"]] = None
Review comment:
I mildly disagree :) In general, these "internals" pop up all over the place, so we cannot really skip them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #34424: [SPARK-37144][PYTHON] Inline type hints for python/pyspark/file.py
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #34424:
URL: https://github.com/apache/spark/pull/34424#issuecomment-953715368
**[Test build #144713 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144713/testReport)** for PR 34424 at commit [`1385e67`](https://github.com/apache/spark/commit/1385e6714514ee3ce1b7bf2d0b6a109136fb5b42).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dchvn commented on pull request #34424: [SPARK-37144][PYTHON] Inline type hints for python/pyspark/file.py
Posted by GitBox <gi...@apache.org>.
dchvn commented on pull request #34424:
URL: https://github.com/apache/spark/pull/34424#issuecomment-954443276
thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34424: [SPARK-37144][PYTHON] Inline type hints for python/pyspark/file.py
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34424:
URL: https://github.com/apache/spark/pull/34424#issuecomment-953775747
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/49182/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org