You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by James Peach <jp...@apache.org> on 2017/10/20 21:19:00 UTC
Review Request 63189: Refactored installing rlimits in the container
launch.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63189/
-----------------------------------------------------------
Review request for mesos and Jie Yu.
Repository: mesos
Description
-------
Hoisted the platform-dependent rlimit installation into a helper
function to improve readability. Improved the error message to
specify which rlimit we failed to set.
Diffs
-----
src/slave/containerizer/mesos/launch.cpp d1372987cfbd3761d344479992b2ca6bb918540c
Diff: https://reviews.apache.org/r/63189/diff/1/
Testing
-------
make check (Fedora 26).
Thanks,
James Peach
Re: Review Request 63189: Refactored installing rlimits in the
container launch.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63189/#review188874
-----------------------------------------------------------
Ship it!
Ship It!
- Jie Yu
On Oct. 20, 2017, 9:19 p.m., James Peach wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63189/
> -----------------------------------------------------------
>
> (Updated Oct. 20, 2017, 9:19 p.m.)
>
>
> Review request for mesos and Jie Yu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Hoisted the platform-dependent rlimit installation into a helper
> function to improve readability. Improved the error message to
> specify which rlimit we failed to set.
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/launch.cpp d1372987cfbd3761d344479992b2ca6bb918540c
>
>
> Diff: https://reviews.apache.org/r/63189/diff/1/
>
>
> Testing
> -------
>
> make check (Fedora 26).
>
>
> Thanks,
>
> James Peach
>
>