You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@devlake.apache.org by "aubertaa (via GitHub)" <gi...@apache.org> on 2023/03/14 08:53:04 UTC
[GitHub] [incubator-devlake] aubertaa opened a new issue, #4657: [Bug][Jenkins scopes] Trying to add jenkins scopes in a blueprint fails if at least one jenkins job contains URL specific chars
aubertaa opened a new issue, #4657:
URL: https://github.com/apache/incubator-devlake/issues/4657
### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/incubator-devlake/issues?q=is%3Aissue) and found no similar issues.
### What happened
hi
the jenkins scope selector fails when at least 1 job in the whole list contains '/' character. It tries to call jenkins API with non encoded job name which leads to a 404 error (see screen). This makes jenkins scope selection impossible:
if i may suggest, var "repoId" should be URL encoded here as job name may contain "either reserved or potentially unsafe when used in URLs" : https://github.com/apache/incubator-devlake/blob/d708a808c5808be330998c8bbdaf1e02b8d004d8/config-ui/src/plugins/components/data-scope/api.ts#L22
### What do you expect to happen
- URL specific chars should be encoded when repoId is used as a path parameter
- call to jenkins API should success for each existing job (or at least failure should not be a blocker to add other jobs in scope)
### How to reproduce
- link devlake with a jenkins instance containing a job named "test/myjob"
- try to add scope from this jenkins in a new blueprint
### Anything else
_No response_
### Version
v0.15.0
### Are you willing to submit PR?
- [ ] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] aubertaa commented on issue #4657: [Bug][Jenkins scopes] Trying to add jenkins scopes in a blueprint fails if at least one jenkins job contains URL specific chars
Posted by "aubertaa (via GitHub)" <gi...@apache.org>.
aubertaa commented on issue #4657:
URL: https://github.com/apache/incubator-devlake/issues/4657#issuecomment-1468148903
I just noticed that scope is not well selected only **when editing a blueprint which is not in a project**.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] d4x1 commented on issue #4657: [Bug][Jenkins scopes] Trying to add jenkins scopes in a blueprint fails if at least one jenkins job contains URL specific chars
Posted by "d4x1 (via GitHub)" <gi...@apache.org>.
d4x1 commented on issue #4657:
URL: https://github.com/apache/incubator-devlake/issues/4657#issuecomment-1468046895
Decoding path parameters is not a good idea, I think putting `repoId` in query string is a good way to solve this issue.
This will break the compatibility of API.
As for the failure blocks following action, It shouldn't happen, because it's just a 404 error. Can you offer more information about it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] klesh commented on issue #4657: [Bug][Jenkins scopes] Trying to add jenkins scopes in a blueprint fails if at least one jenkins job contains URL specific chars
Posted by "klesh (via GitHub)" <gi...@apache.org>.
klesh commented on issue #4657:
URL: https://github.com/apache/incubator-devlake/issues/4657#issuecomment-1471626138
Hi, @aubertaa , thanks for the quick response, we might have to solve the problem later due to limited bandwidth.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] d4x1 commented on issue #4657: [Bug][Jenkins scopes] Trying to add jenkins scopes in a blueprint fails if at least one jenkins job contains URL specific chars
Posted by "d4x1 (via GitHub)" <gi...@apache.org>.
d4x1 commented on issue #4657:
URL: https://github.com/apache/incubator-devlake/issues/4657#issuecomment-1468321819
I can help to fix the backend API, but we'd better get some advice from the core maintain team.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] github-actions[bot] closed issue #4657: [Bug][Jenkins scopes] Trying to add jenkins scopes in a blueprint fails if at least one jenkins job contains URL specific chars
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed issue #4657: [Bug][Jenkins scopes] Trying to add jenkins scopes in a blueprint fails if at least one jenkins job contains URL specific chars
URL: https://github.com/apache/incubator-devlake/issues/4657
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] d4x1 commented on issue #4657: [Bug][Jenkins scopes] Trying to add jenkins scopes in a blueprint fails if at least one jenkins job contains URL specific chars
Posted by "d4x1 (via GitHub)" <gi...@apache.org>.
d4x1 commented on issue #4657:
URL: https://github.com/apache/incubator-devlake/issues/4657#issuecomment-1468316497
> hi, thanks for this reply. Indeed letting you fully the choice of how to handle this case of handling URL specific chars in jenkins jobs names. If this could help, here a recording showing : the 404 errors for job names containing "/" char + no selected scope whereas selection has been made and a message confirmed that changes were successfully saved.
>
>  [  ](https://user-images.githubusercontent.com/14087776/225016498-ce92af6d-2661-4b3c-a902-7f25bb02db63.gif) [ ](https://user-images.githubusercontent.com/14087776/225016498-ce92af6d-2661-4b3c-a902-7f25bb02db63.gif)
>
> Thanks
The success message is really confusing. It looks like this message doesn't depend on API's success(or any other) response, just a wrong state transformation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] aubertaa commented on issue #4657: [Bug][Jenkins scopes] Trying to add jenkins scopes in a blueprint fails if at least one jenkins job contains URL specific chars
Posted by "aubertaa (via GitHub)" <gi...@apache.org>.
aubertaa commented on issue #4657:
URL: https://github.com/apache/incubator-devlake/issues/4657#issuecomment-1469712051
you may create "multibranch pipeline" and create a new branch named with a "/" in your git repository.
Then scan your branches from jenkins, it will create a job named like the branch.
Regards,
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] aubertaa commented on issue #4657: [Bug][Jenkins scopes] Trying to add jenkins scopes in a blueprint fails if at least one jenkins job contains URL specific chars
Posted by "aubertaa (via GitHub)" <gi...@apache.org>.
aubertaa commented on issue #4657:
URL: https://github.com/apache/incubator-devlake/issues/4657#issuecomment-1468109709
hi,
thanks for this reply. Indeed letting you fully the choice of how to handle this case of handling URL specific chars in jenkins jobs names.
If this could help, here a recording showing : the 404 errors for job names containing "/" char + no selected scope whereas selection has been made and a message confirmed that changes were successfully saved.
Thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] github-actions[bot] closed issue #4657: [Bug][Jenkins scopes] Trying to add jenkins scopes in a blueprint fails if at least one jenkins job contains URL specific chars
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed issue #4657: [Bug][Jenkins scopes] Trying to add jenkins scopes in a blueprint fails if at least one jenkins job contains URL specific chars
URL: https://github.com/apache/incubator-devlake/issues/4657
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] github-actions[bot] commented on issue #4657: [Bug][Jenkins scopes] Trying to add jenkins scopes in a blueprint fails if at least one jenkins job contains URL specific chars
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on issue #4657:
URL: https://github.com/apache/incubator-devlake/issues/4657#issuecomment-1522572560
This issue has been closed because it has not received response for too long time. You could reopen it if you encountered similar problems in the future.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] github-actions[bot] commented on issue #4657: [Bug][Jenkins scopes] Trying to add jenkins scopes in a blueprint fails if at least one jenkins job contains URL specific chars
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on issue #4657:
URL: https://github.com/apache/incubator-devlake/issues/4657#issuecomment-1535550417
This issue has been closed because it has not received response for too long time. You could reopen it if you encountered similar problems in the future.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] github-actions[bot] commented on issue #4657: [Bug][Jenkins scopes] Trying to add jenkins scopes in a blueprint fails if at least one jenkins job contains URL specific chars
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on issue #4657:
URL: https://github.com/apache/incubator-devlake/issues/4657#issuecomment-1510006664
This issue has been automatically marked as stale because it has not had recent activity for 30 days. It will be closed in next 7 days if no further activity occurs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] klesh commented on issue #4657: [Bug][Jenkins scopes] Trying to add jenkins scopes in a blueprint fails if at least one jenkins job contains URL specific chars
Posted by "klesh (via GitHub)" <gi...@apache.org>.
klesh commented on issue #4657:
URL: https://github.com/apache/incubator-devlake/issues/4657#issuecomment-1469703078
@aubertaa we tried to reproduce the problem and ran into a problem, seems like the jenkins would allow us to do so:
What is your jenkins version and how did you create that specific scope?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org