You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@myfaces.apache.org by "Michael Freedman (JIRA)" <de...@myfaces.apache.org> on 2011/02/14 22:34:02 UTC
[jira] Created: (MYFACES-3042) CCE: when running in portlet: Remove
Servlet dependencies in FaceletViewDeclarationLanguage.java
CCE: when running in portlet: Remove Servlet dependencies in FaceletViewDeclarationLanguage.java
------------------------------------------------------------------------------------------------
Key: MYFACES-3042
URL: https://issues.apache.org/jira/browse/MYFACES-3042
Project: MyFaces Core
Issue Type: Bug
Components: Portlet_Support
Affects Versions: 2.0.5-SNAPSHOT
Reporter: Michael Freedman
In FaceletViewDeclarationLanguage.java: createResponseWriter(), getResponseEncoding(), handleFaceletNotFound(), and sendSourceNotFound() each cast to Servlet object. This causes ClassCastExceptions when run in a portlet environment. Each of these calls/casts can be removed and ExternalContext APIs can be used instead to get/set the needed information from the request or response object.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (MYFACES-3042) CCE: when running in portlet: Remove
Servlet dependencies in FaceletViewDeclarationLanguage.java
Posted by "Michael Freedman (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/MYFACES-3042?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Michael Freedman updated MYFACES-3042:
--------------------------------------
Status: Patch Available (was: Open)
> CCE: when running in portlet: Remove Servlet dependencies in FaceletViewDeclarationLanguage.java
> ------------------------------------------------------------------------------------------------
>
> Key: MYFACES-3042
> URL: https://issues.apache.org/jira/browse/MYFACES-3042
> Project: MyFaces Core
> Issue Type: Bug
> Components: Portlet_Support
> Affects Versions: 2.0.5-SNAPSHOT
> Reporter: Michael Freedman
> Attachments: jira-myfaces-3042.patch
>
>
> In FaceletViewDeclarationLanguage.java: createResponseWriter(), getResponseEncoding(), handleFaceletNotFound(), and sendSourceNotFound() each cast to Servlet object. This causes ClassCastExceptions when run in a portlet environment. Each of these calls/casts can be removed and ExternalContext APIs can be used instead to get/set the needed information from the request or response object.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (MYFACES-3042) CCE: when running in portlet: Remove
Servlet dependencies in FaceletViewDeclarationLanguage.java
Posted by "Leonardo Uribe (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/MYFACES-3042?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Leonardo Uribe updated MYFACES-3042:
------------------------------------
Resolution: Fixed
Fix Version/s: 2.0.5-SNAPSHOT
Assignee: Leonardo Uribe
Status: Resolved (was: Patch Available)
Thanks to Michael Freedman for provide this patch
> CCE: when running in portlet: Remove Servlet dependencies in FaceletViewDeclarationLanguage.java
> ------------------------------------------------------------------------------------------------
>
> Key: MYFACES-3042
> URL: https://issues.apache.org/jira/browse/MYFACES-3042
> Project: MyFaces Core
> Issue Type: Bug
> Components: Portlet_Support
> Affects Versions: 2.0.5-SNAPSHOT
> Reporter: Michael Freedman
> Assignee: Leonardo Uribe
> Fix For: 2.0.5-SNAPSHOT
>
> Attachments: jira-myfaces-3042.patch
>
>
> In FaceletViewDeclarationLanguage.java: createResponseWriter(), getResponseEncoding(), handleFaceletNotFound(), and sendSourceNotFound() each cast to Servlet object. This causes ClassCastExceptions when run in a portlet environment. Each of these calls/casts can be removed and ExternalContext APIs can be used instead to get/set the needed information from the request or response object.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MYFACES-3042) CCE: when running in portlet:
Remove Servlet dependencies in FaceletViewDeclarationLanguage.java
Posted by "Mike Kienenberger (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/MYFACES-3042?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12994548#comment-12994548 ]
Mike Kienenberger commented on MYFACES-3042:
--------------------------------------------
Michael, you should have permissions to fix this yourself if you desire.
> CCE: when running in portlet: Remove Servlet dependencies in FaceletViewDeclarationLanguage.java
> ------------------------------------------------------------------------------------------------
>
> Key: MYFACES-3042
> URL: https://issues.apache.org/jira/browse/MYFACES-3042
> Project: MyFaces Core
> Issue Type: Bug
> Components: Portlet_Support
> Affects Versions: 2.0.5-SNAPSHOT
> Reporter: Michael Freedman
>
> In FaceletViewDeclarationLanguage.java: createResponseWriter(), getResponseEncoding(), handleFaceletNotFound(), and sendSourceNotFound() each cast to Servlet object. This causes ClassCastExceptions when run in a portlet environment. Each of these calls/casts can be removed and ExternalContext APIs can be used instead to get/set the needed information from the request or response object.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MYFACES-3042) CCE: when running in portlet:
Remove Servlet dependencies in FaceletViewDeclarationLanguage.java
Posted by "Michael Freedman (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/MYFACES-3042?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12994511#comment-12994511 ]
Michael Freedman commented on MYFACES-3042:
-------------------------------------------
FYI ... when you make these changes it looks like you will also have to implement an ExternalContext (stub) to use in the test harness as one doesn't seem to exist at the moment -- and these new 2.0 methods through an exception (from the javax.faces.context impl) if not implemented.
> CCE: when running in portlet: Remove Servlet dependencies in FaceletViewDeclarationLanguage.java
> ------------------------------------------------------------------------------------------------
>
> Key: MYFACES-3042
> URL: https://issues.apache.org/jira/browse/MYFACES-3042
> Project: MyFaces Core
> Issue Type: Bug
> Components: Portlet_Support
> Affects Versions: 2.0.5-SNAPSHOT
> Reporter: Michael Freedman
>
> In FaceletViewDeclarationLanguage.java: createResponseWriter(), getResponseEncoding(), handleFaceletNotFound(), and sendSourceNotFound() each cast to Servlet object. This causes ClassCastExceptions when run in a portlet environment. Each of these calls/casts can be removed and ExternalContext APIs can be used instead to get/set the needed information from the request or response object.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MYFACES-3042) CCE: when running in portlet:
Remove Servlet dependencies in FaceletViewDeclarationLanguage.java
Posted by "Michael Freedman (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/MYFACES-3042?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12994882#comment-12994882 ]
Michael Freedman commented on MYFACES-3042:
-------------------------------------------
I have attached a potential patch -- Apologies for not just making the changes but (1) this change breaks an automated test that is part of the build as it seems the test environment doesn't provide its own stub impl of the new JSF 2.0 ExternalContext methods that these changes rely on -- and I have no clue how to address those and (2) the various paperwork Oracle made me sign to allow me to participate in Apache only allows me to submit work related to the Portlet Bridge project -- MyFaces work has to be submitted by those from Oracle signed up to do that.
> CCE: when running in portlet: Remove Servlet dependencies in FaceletViewDeclarationLanguage.java
> ------------------------------------------------------------------------------------------------
>
> Key: MYFACES-3042
> URL: https://issues.apache.org/jira/browse/MYFACES-3042
> Project: MyFaces Core
> Issue Type: Bug
> Components: Portlet_Support
> Affects Versions: 2.0.5-SNAPSHOT
> Reporter: Michael Freedman
> Attachments: jira-myfaces-3042.patch
>
>
> In FaceletViewDeclarationLanguage.java: createResponseWriter(), getResponseEncoding(), handleFaceletNotFound(), and sendSourceNotFound() each cast to Servlet object. This causes ClassCastExceptions when run in a portlet environment. Each of these calls/casts can be removed and ExternalContext APIs can be used instead to get/set the needed information from the request or response object.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira