You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2019/12/06 18:42:21 UTC
[GitHub] [incubator-superset] codecov-io commented on issue #8770: Re-enable
pylint for some model files
codecov-io commented on issue #8770: Re-enable pylint for some model files
URL: https://github.com/apache/incubator-superset/pull/8770#issuecomment-562690446
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8770?src=pr&el=h1) Report
> Merging [#8770](https://codecov.io/gh/apache/incubator-superset/pull/8770?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/665e94784ca75257df6fe1455e5cdfc41e8c5e46?src=pr&el=desc) will **decrease** coverage by `6.23%`.
> The diff coverage is `67.36%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/8770?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #8770 +/- ##
==========================================
- Coverage 72.07% 65.83% -6.24%
==========================================
Files 123 482 +359
Lines 12844 24158 +11314
Branches 0 2770 +2770
==========================================
+ Hits 9257 15905 +6648
- Misses 3587 8075 +4488
- Partials 0 178 +178
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/8770?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/models/sql\_lab.py](https://codecov.io/gh/apache/incubator-superset/pull/8770/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL3NxbF9sYWIucHk=) | `90.99% <ø> (ø)` | :arrow_up: |
| [superset/models/tags.py](https://codecov.io/gh/apache/incubator-superset/pull/8770/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL3RhZ3MucHk=) | `58.58% <ø> (ø)` | :arrow_up: |
| [superset/models/annotations.py](https://codecov.io/gh/apache/incubator-superset/pull/8770/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2Fubm90YXRpb25zLnB5) | `92% <100%> (ø)` | :arrow_up: |
| [superset/models/schedules.py](https://codecov.io/gh/apache/incubator-superset/pull/8770/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL3NjaGVkdWxlcy5weQ==) | `88.88% <50%> (-2.03%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/8770/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `83.09% <59.32%> (ø)` | :arrow_up: |
| [superset/models/helpers.py](https://codecov.io/gh/apache/incubator-superset/pull/8770/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2hlbHBlcnMucHk=) | `86.41% <81.25%> (+0.14%)` | :arrow_up: |
| [superset/assets/src/components/Checkbox.jsx](https://codecov.io/gh/apache/incubator-superset/pull/8770/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9jb21wb25lbnRzL0NoZWNrYm94LmpzeA==) | `100% <0%> (ø)` | |
| [.../assets/src/dashboard/reducers/dashboardFilters.js](https://codecov.io/gh/apache/incubator-superset/pull/8770/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9kYXNoYm9hcmQvcmVkdWNlcnMvZGFzaGJvYXJkRmlsdGVycy5qcw==) | `88.46% <0%> (ø)` | |
| [...ets/src/dashboard/components/dnd/DragDroppable.jsx](https://codecov.io/gh/apache/incubator-superset/pull/8770/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9kYXNoYm9hcmQvY29tcG9uZW50cy9kbmQvRHJhZ0Ryb3BwYWJsZS5qc3g=) | `94.59% <0%> (ø)` | |
| [superset/assets/src/components/EditableTitle.jsx](https://codecov.io/gh/apache/incubator-superset/pull/8770/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9jb21wb25lbnRzL0VkaXRhYmxlVGl0bGUuanN4) | `80.28% <0%> (ø)` | |
| ... and [355 more](https://codecov.io/gh/apache/incubator-superset/pull/8770/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8770?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8770?src=pr&el=footer). Last update [665e947...7fd15f2](https://codecov.io/gh/apache/incubator-superset/pull/8770?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org