You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "slmg (via GitHub)" <gi...@apache.org> on 2023/04/01 18:58:50 UTC
[GitHub] [airflow] slmg opened a new issue, #30420: Chart should not create Redis secrets while using the KubernetesExecutor
slmg opened a new issue, #30420:
URL: https://github.com/apache/airflow/issues/30420
### Official Helm Chart version
1.8.0 (latest released)
### Apache Airflow version
2.5.1
### Kubernetes Version
1.21.14
### Helm Chart configuration
```yaml
# values.yaml
executor: "KubernetesExecutor"
```
### Docker Image customizations
None.
### What happened
The [redis secrets](https://github.com/apache/airflow/blob/2.5.1/chart/templates/secrets/redis-secrets.yaml) got created
### What you think should happen instead
Given all the resources defined in [./chart/templates/redis](https://github.com/apache/airflow/tree/2.5.1/chart/templates/redis) contain the below condition, it does not seem right to me to get Redis secrets created in the context of the `KubernetesExecutor`.
```go
{{- if and .Values.redis.enabled (or (eq .Values.executor "CeleryExecutor") (eq .Values.executor "CeleryKubernetesExecutor")) }}
```
Redis secrets might have been missed when this condition was added, because they are located in a different folder?
### How to reproduce
Render helm templates
```sh
helm template test apache-airflow/airflow --version --values values.yaml > rendered.yaml
```
### Anything else
_No response_
### Are you willing to submit PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://github.com/apache/airflow/blob/main/CODE_OF_CONDUCT.md)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] boring-cyborg[bot] commented on issue #30420: Chart should not create Redis secrets while using the KubernetesExecutor
Posted by "boring-cyborg[bot] (via GitHub)" <gi...@apache.org>.
boring-cyborg[bot] commented on issue #30420:
URL: https://github.com/apache/airflow/issues/30420#issuecomment-1493076035
Thanks for opening your first issue here! Be sure to follow the issue template! If you are willing to raise PR to address this issue please do so, no need to wait for approval.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] amoghrajesh commented on issue #30420: Chart should not create Redis secrets while using the KubernetesExecutor
Posted by "amoghrajesh (via GitHub)" <gi...@apache.org>.
amoghrajesh commented on issue #30420:
URL: https://github.com/apache/airflow/issues/30420#issuecomment-1633561872
As per discussions on this issue itself and the PR: https://github.com/apache/airflow/pull/32141, this looks to be how it is designed and it is expected behaviour here. Closing the issue as expected behaviour.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] amoghrajesh commented on issue #30420: Chart should not create Redis secrets while using the KubernetesExecutor
Posted by "amoghrajesh (via GitHub)" <gi...@apache.org>.
amoghrajesh commented on issue #30420:
URL: https://github.com/apache/airflow/issues/30420#issuecomment-1607176930
@hussein-awala continuing the effort which went stale here: https://github.com/apache/airflow/pull/32141 in a new PR. Take a look when you have some time, it is a simple conditional added
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] hussein-awala commented on issue #30420: Chart should not create Redis secrets while using the KubernetesExecutor
Posted by "hussein-awala (via GitHub)" <gi...@apache.org>.
hussein-awala commented on issue #30420:
URL: https://github.com/apache/airflow/issues/30420#issuecomment-1531099656
@amoghrajesh there is an open PR #30423, you can read the comments and join the discussion
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] hussein-awala commented on issue #30420: Chart should not create Redis secrets while using the KubernetesExecutor
Posted by "hussein-awala (via GitHub)" <gi...@apache.org>.
hussein-awala commented on issue #30420:
URL: https://github.com/apache/airflow/issues/30420#issuecomment-1493131881
@slmg assigned you
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] amoghrajesh commented on issue #30420: Chart should not create Redis secrets while using the KubernetesExecutor
Posted by "amoghrajesh (via GitHub)" <gi...@apache.org>.
amoghrajesh commented on issue #30420:
URL: https://github.com/apache/airflow/issues/30420#issuecomment-1557708427
I was checking the discussions @hussein-awala. Looks like the PR has gone stale.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] amoghrajesh commented on issue #30420: Chart should not create Redis secrets while using the KubernetesExecutor
Posted by "amoghrajesh (via GitHub)" <gi...@apache.org>.
amoghrajesh commented on issue #30420:
URL: https://github.com/apache/airflow/issues/30420#issuecomment-1530839848
Is anyone actively working on this issue @hussein-awala @slmg?
I would not mind fixing this if nobody is working on this now :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] amoghrajesh closed issue #30420: Chart should not create Redis secrets while using the KubernetesExecutor
Posted by "amoghrajesh (via GitHub)" <gi...@apache.org>.
amoghrajesh closed issue #30420: Chart should not create Redis secrets while using the KubernetesExecutor
URL: https://github.com/apache/airflow/issues/30420
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org