You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@gobblin.apache.org by GitBox <gi...@apache.org> on 2020/03/19 23:31:13 UTC
[GitHub] [incubator-gobblin] sv2000 opened a new pull request #2933: GOBBLIN-1091: Pass Yarn application id as part of AppMaster and YarnT…
sv2000 opened a new pull request #2933: GOBBLIN-1091: Pass Yarn application id as part of AppMaster and YarnT…
URL: https://github.com/apache/incubator-gobblin/pull/2933
…askRunner's start up command
Dear Gobblin maintainers,
Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!
### JIRA
- [x] My PR addresses the following [Gobblin JIRA](https://issues.apache.org/jira/browse/GOBBLIN/) issues and references them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR"
- https://issues.apache.org/jira/browse/GOBBLIN-1091
### Description
- [x] Here are some details about my PR, including screenshots (if applicable):
Currently, the application id is retrieved from the container id in Gobblin Yarn applications. This makes it hard to isolate the source of misconfigurations in the application work directory (i.e. Yarn vs Helix vs Gobblin), which is generated dynamically using Yarn application name and Yarn application id. Having the Yarn application id generated in one place (i.e. GobblinYarnAppLauncher) and passed to all participants in the Yarn application ensures a more explainable and debuggable behavior in how application working directories are set.
### Tests
- [x] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:
Modified existing unit tests.
### Commits
- [x] My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
2. Subject is limited to 50 characters
3. Subject does not end with a period
4. Subject uses the imperative mood ("add", not "adding")
5. Body wraps at 72 characters
6. Body explains "what" and "why", not "how"
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-gobblin] asfgit closed pull request #2933: GOBBLIN-1091: Pass Yarn application id as part of AppMaster and YarnT…
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #2933: GOBBLIN-1091: Pass Yarn application id as part of AppMaster and YarnT…
URL: https://github.com/apache/incubator-gobblin/pull/2933
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services