You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/01/23 09:38:43 UTC

[GitHub] [arrow-rs] jhorstmann commented on pull request #1219: Do not concatenate identical dictionaries

jhorstmann commented on pull request #1219:
URL: https://github.com/apache/arrow-rs/pull/1219#issuecomment-1019447411


   Looks good to me. I initially thought `ptr_eq` for dictionary values could get away with only comparing the data buffer, but in theory the same buffer could be combined with different offsets or validity. So really need to compare all buffers and child data as int this PR.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org