You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by "mrproliu (via GitHub)" <gi...@apache.org> on 2024/10/12 00:45:59 UTC
[PR] support query endpoint list with time range [skywalking]
mrproliu opened a new pull request, #12693:
URL: https://github.com/apache/skywalking/pull/12693
- [ ] If this pull request closes/resolves/fixes an existing issue, replace the issue number. Closes #<issue number>.
- [x] Update the [`CHANGES` log](https://github.com/apache/skywalking/blob/master/docs/en/changes/changes.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] support query endpoint list with time range [skywalking]
Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng merged PR #12693:
URL: https://github.com/apache/skywalking/pull/12693
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] support query endpoint list with time range [skywalking]
Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng commented on code in PR #12693:
URL: https://github.com/apache/skywalking/pull/12693#discussion_r1797705594
##########
oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/analysis/manual/endpoint/EndpointTraffic.java:
##########
@@ -48,6 +48,7 @@ public class EndpointTraffic extends Metrics {
public static final String SERVICE_ID = "service_id";
public static final String NAME = "endpoint_traffic_name";
+ public static final String LAST_PING_TIME_BUCKET = "last_ping";
Review Comment:
https://github.com/apache/skywalking/blob/29618d7f2e795f1822d46015c23edc3f6b0c66be/oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/analysis/worker/MetricsPersistentWorker.java#L252-L257
According to this, an existing metric(if no_update=true) should not re-entry the `prepareRequests` list, and end in database again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] support query endpoint list with time range [skywalking]
Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng commented on code in PR #12693:
URL: https://github.com/apache/skywalking/pull/12693#discussion_r1797611960
##########
oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/analysis/manual/endpoint/EndpointTraffic.java:
##########
@@ -48,6 +48,7 @@ public class EndpointTraffic extends Metrics {
public static final String SERVICE_ID = "service_id";
public static final String NAME = "endpoint_traffic_name";
+ public static final String LAST_PING_TIME_BUCKET = "last_ping";
Review Comment:
I think endpoint traffic declared no update.
Could you verify the data in database?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] support query endpoint list with time range [skywalking]
Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng commented on code in PR #12693:
URL: https://github.com/apache/skywalking/pull/12693#discussion_r1799480073
##########
docs/en/changes/changes.md:
##########
@@ -7,6 +7,7 @@
* Reduce the count of process index and adding time range when query process index.
* Bump up Apache commons-io to 2.17.0.
* Polish eBPF so11y metrics and add error count for query metrics.
+* Support query endpoint list with duration parameter.
Review Comment:
```suggestion
* Support query endpoint list with duration parameter(optional).
* Change the endpoint_traffic to updatable for the additional column `last_ping`.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] support query endpoint list with time range [skywalking]
Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng commented on code in PR #12693:
URL: https://github.com/apache/skywalking/pull/12693#discussion_r1797638562
##########
oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/analysis/manual/endpoint/EndpointTraffic.java:
##########
@@ -48,6 +48,7 @@ public class EndpointTraffic extends Metrics {
public static final String SERVICE_ID = "service_id";
public static final String NAME = "endpoint_traffic_name";
+ public static final String LAST_PING_TIME_BUCKET = "last_ping";
Review Comment:
Check here,
MetricsExtension(supportDownSampling = false, supportUpdate = false)
We declared this metric doesn't support update. What happens?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] support query endpoint list with time range [skywalking]
Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng commented on PR #12693:
URL: https://github.com/apache/skywalking/pull/12693#issuecomment-2408275430
fyi @apache/skywalking-committers We are open endpoint keep alive due to r3 is stable and restful APIs are not our concern to cause high cardinal number issues.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] support query endpoint list with time range [skywalking]
Posted by "mrproliu (via GitHub)" <gi...@apache.org>.
mrproliu commented on code in PR #12693:
URL: https://github.com/apache/skywalking/pull/12693#discussion_r1797629148
##########
oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/analysis/manual/endpoint/EndpointTraffic.java:
##########
@@ -48,6 +48,7 @@ public class EndpointTraffic extends Metrics {
public static final String SERVICE_ID = "service_id";
public static final String NAME = "endpoint_traffic_name";
+ public static final String LAST_PING_TIME_BUCKET = "last_ping";
Review Comment:
I have checked in Elasticsearch storage, looks like the update successful.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org