You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hc.apache.org by "silver9886 (JIRA)" <ji...@apache.org> on 2017/08/02 09:25:00 UTC

[jira] [Created] (HTTPCORE-480) improve the code in check timeout

silver9886 created HTTPCORE-480:
-----------------------------------

             Summary: improve the code in check timeout
                 Key: HTTPCORE-480
                 URL: https://issues.apache.org/jira/browse/HTTPCORE-480
             Project: HttpComponents HttpCore
          Issue Type: Improvement
          Components: HttpCore NIO
    Affects Versions: 4.4.6
            Reporter: silver9886
            Priority: Critical
             Fix For: 4.4.7
         Attachments: BaseIOReactor.java

change the code in org.apache.http.impl.nio.reactor.BaseIOReactor:
        if( (currentTime - this.lastTimeoutCheck) >= this.timeoutCheckInterval) ->
   if( (currentTime - this.lastTimeoutCheck) >= this.timeoutCheckInterval + 2)

because :the code will run for a time and network tranport expend the time too.  So currentTime - this.lastTimeoutCheck should be 
larger than selectTimeout in order to check timeout. In this case , This will make the code more efficiency.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org