[jira] [Commented] (OAK-7070) rep:excerpt selector broken as regression of OAK-6750

["Dirk Rudolph (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OAK-7070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16294060#comment-16294060 ] 

Dirk Rudolph commented on OAK-7070:
-----------------------------------

As far as I can see there are the following selectors in sql2 queries for excerpts supported:

1) [rep:excerpt]
2) [rep:excerpt(.)]
3) [rep:excerpt(propertyName)]

The expression previous to OAK-6750 includes only 1), where as a change to {{startsWith}} with trailing opening bracket (similar as to the facets) would only include 2) and 3). Though without the trailing opening bracket a bit to much might get consumed there so my suggestion is to use a disjunction of the both above. 

> rep:excerpt selector broken as regression of OAK-6750
> -----------------------------------------------------
>
>                 Key: OAK-7070
>                 URL: https://issues.apache.org/jira/browse/OAK-7070
>             Project: Jackrabbit Oak
>          Issue Type: Bug
>    Affects Versions: 1.8
>            Reporter: Dirk Rudolph
>
> The change made here:
> https://github.com/apache/jackrabbit-oak/commit/00c94b71293abcae6d76bb162c3f55c7d09b702e#diff-d4bdf443c61f24b634f33aab607e2114
> breaks the logic in line 676:
> {{else if (oakPropertyName.equals(QueryConstants.REP_EXCERPT + "("))}}
> This statement doesn't make much sense considering a query like {{select \[rep:excerpt] from \[test:Page] as page where contains(*, 'term*')}} or even {{select \[rep:excerpt(text)] from \[test:Page] as page where contains(page.\[text], 'term*')}}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)