You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@activemq.apache.org by franz1981 <gi...@git.apache.org> on 2018/03/28 15:10:39 UTC
[GitHub] activemq-artemis pull request #1977: ARTEMIS-1774 Node Manager Store table n...
GitHub user franz1981 opened a pull request:
https://github.com/apache/activemq-artemis/pull/1977
ARTEMIS-1774 Node Manager Store table name should be configurable
It exposes the table name configuration for:
- CLI command
- configuration file
The docs are updated as well.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/franz1981/activemq-artemis ARTEMIS-1774
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/activemq-artemis/pull/1977.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1977
----
commit 89a9b50ffa4097c3817515e4bf0ba901657075be
Author: Francesco Nigro <ni...@...>
Date: 2018-03-28T15:07:04Z
ARTEMIS-1774 Node Manager Store table name should be configurable
It exposes the table name configuration for:
- CLI command
- configuration file
The docs are updated as well.
----
---
[GitHub] activemq-artemis issue #1977: ARTEMIS-1774 Node Manager Store table name sho...
Posted by franz1981 <gi...@git.apache.org>.
Github user franz1981 commented on the issue:
https://github.com/apache/activemq-artemis/pull/1977
@clebertsuconic I have added CLI `Create` and `DBOption` configuration too.
The first because it was already handling the other JDBC HA configuration options, while the second one because it seems to deal with each JDBC table name configuration, but probably it is not necessary.
Please let me know if I need change/drop any of them, because unecessary :+1:
---
[GitHub] activemq-artemis pull request #1977: ARTEMIS-1774 Node Manager Store table n...
Posted by clebertsuconic <gi...@git.apache.org>.
Github user clebertsuconic commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1977#discussion_r177790312
--- Diff: artemis-cli/src/main/java/org/apache/activemq/artemis/cli/commands/tools/DBOption.java ---
@@ -74,9 +74,12 @@
@Option(name = "--jdbc-large-message-table-name", description = "Name of the large messages table")
private String jdbcLargeMessages = ActiveMQDefaultConfiguration.getDefaultLargeMessagesTableName();
- @Option(name = "--jdbc-page-store-table-name", description = "Name of the page sotre messages table")
+ @Option(name = "--jdbc-page-store-table-name", description = "Name of the page store messages table")
private String jdbcPageStore = ActiveMQDefaultConfiguration.getDefaultPageStoreTableName();
--- End diff --
There's something wrong here...
the default should be what's on the XML.
---
[GitHub] activemq-artemis pull request #1977: ARTEMIS-1774 Node Manager Store table n...
Posted by clebertsuconic <gi...@git.apache.org>.
Github user clebertsuconic commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1977#discussion_r177789837
--- Diff: artemis-cli/src/main/java/org/apache/activemq/artemis/cli/commands/Create.java ---
@@ -278,9 +278,12 @@
@Option(name = "--jdbc-large-message-table-name", description = "Name of the large messages table")
private String jdbcLargeMessages = ActiveMQDefaultConfiguration.getDefaultLargeMessagesTableName();
- @Option(name = "--jdbc-page-store-table-name", description = "Name of the page sotre messages table")
+ @Option(name = "--jdbc-page-store-table-name", description = "Name of the page store messages table")
--- End diff --
:)
---
[GitHub] activemq-artemis issue #1977: ARTEMIS-1774 Node Manager Store table name sho...
Posted by clebertsuconic <gi...@git.apache.org>.
Github user clebertsuconic commented on the issue:
https://github.com/apache/activemq-artemis/pull/1977
it looks good. will wait travis CI and merge it.
---
[GitHub] activemq-artemis pull request #1977: ARTEMIS-1774 Node Manager Store table n...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/activemq-artemis/pull/1977
---
[GitHub] activemq-artemis pull request #1977: ARTEMIS-1774 Node Manager Store table n...
Posted by clebertsuconic <gi...@git.apache.org>.
Github user clebertsuconic commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1977#discussion_r177791184
--- Diff: artemis-cli/src/main/java/org/apache/activemq/artemis/cli/commands/tools/DBOption.java ---
@@ -74,9 +74,12 @@
@Option(name = "--jdbc-large-message-table-name", description = "Name of the large messages table")
private String jdbcLargeMessages = ActiveMQDefaultConfiguration.getDefaultLargeMessagesTableName();
- @Option(name = "--jdbc-page-store-table-name", description = "Name of the page sotre messages table")
+ @Option(name = "--jdbc-page-store-table-name", description = "Name of the page store messages table")
private String jdbcPageStore = ActiveMQDefaultConfiguration.getDefaultPageStoreTableName();
--- End diff --
nm... I thought you missed it on parseDBConfiguration
---