You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/02/29 17:09:07 UTC
[GitHub] [airflow] marwan116 opened a new pull request #7595: Fix typo from
upstream to downstream
marwan116 opened a new pull request #7595: Fix typo from upstream to downstream
URL: https://github.com/apache/airflow/pull/7595
This is how it used to be:
Each DAG Run will contain a task_1 Task Instance and a task_2 Task instance. Both Task Instances will
have ``execution_date`` equal to the DAG Run's ``execution_date``, and each task_2 will be *upstream* of
(depends on) its task_1.
if task_2 depends on task_1 this means task_2 is set downstream of tastk_1 - wondering if I am missing something here - or misreading it
---
Issue link: WILL BE INSERTED BY [boring-cyborg](https://github.com/kaxil/boring-cyborg)
Make sure to mark the boxes below before creating PR: [x]
- [ ] Description above provides context of the change
- [ ] Commit message/PR title starts with `[AIRFLOW-NNNN]`. AIRFLOW-NNNN = JIRA ID<sup>*</sup>
- [ ] Unit tests coverage for changes (not needed for documentation changes)
- [ ] Commits follow "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)"
- [ ] Relevant documentation is updated including usage instructions.
- [ ] I will engage committers as explained in [Contribution Workflow Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).
<sup>*</sup> For document-only changes commit message can start with `[AIRFLOW-XXXX]`.
---
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
Read the [Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines) for more information.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] boring-cyborg[bot] commented on issue #7595:
[AIRFLOW-XXXX] Fix typo from upstream to downstream
Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on issue #7595: [AIRFLOW-XXXX] Fix typo from upstream to downstream
URL: https://github.com/apache/airflow/pull/7595#issuecomment-593505971
Awesome work, congrats on your first merged pull request!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] marwan116 commented on issue #7595: [AIRFLOW-XXXX] Fix
typo from upstream to downstream
Posted by GitBox <gi...@apache.org>.
marwan116 commented on issue #7595: [AIRFLOW-XXXX] Fix typo from upstream to downstream
URL: https://github.com/apache/airflow/pull/7595#issuecomment-593498283
Thank you - so for documentation fixes it is actually XXXX - sorry was a bit confused about that. Fixed it
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] marwan116 commented on issue #7595: [AIRFLOW-6971] Fix
typo from upstream to downstream
Posted by GitBox <gi...@apache.org>.
marwan116 commented on issue #7595: [AIRFLOW-6971] Fix typo from upstream to downstream
URL: https://github.com/apache/airflow/pull/7595#issuecomment-593489182
Thank you for responding - yes I noted that the format should start with [AIRFLOW-XXXX] but I am not sure what XXXX - I just went to JIRA - checked the most recent number (6970) and I incremented mine by one ... would be good if there is a resource on how to create the JIRA issue XXXX number -
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] mik-laj commented on issue #7595: [AIRFLOW-6971] Fix typo
from upstream to downstream
Posted by GitBox <gi...@apache.org>.
mik-laj commented on issue #7595: [AIRFLOW-6971] Fix typo from upstream to downstream
URL: https://github.com/apache/airflow/pull/7595#issuecomment-593496847
Here is pull-request guideline: https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] marwan116 edited a comment on issue #7595: [AIRFLOW-6971]
Fix typo from upstream to downstream
Posted by GitBox <gi...@apache.org>.
marwan116 edited a comment on issue #7595: [AIRFLOW-6971] Fix typo from upstream to downstream
URL: https://github.com/apache/airflow/pull/7595#issuecomment-593489182
Thank you for responding - yes I noted that the format should start with [AIRFLOW-XXXX] but I am not sure what XXXX is supposed to be - I just went to JIRA - checked the most recent number (6970) and I incremented mine by one ... would be good if there is a resource on how to create the JIRA issue XXXX number -
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] feluelle merged pull request #7595: [AIRFLOW-XXXX] Fix
typo from upstream to downstream
Posted by GitBox <gi...@apache.org>.
feluelle merged pull request #7595: [AIRFLOW-XXXX] Fix typo from upstream to downstream
URL: https://github.com/apache/airflow/pull/7595
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services