You are viewing a plain text version of this content. The canonical link for it is here.

Posted to gitbox@activemq.apache.org by GitBox <gi...@apache.org> on 2022/02/07 16:58:06 UTC

[GitHub] [activemq-artemis] jbertram commented on pull request #3795: ARTEMIS-2618 Added optional retry handling on critical I/O Error

jbertram commented on pull request #3795:
URL: https://github.com/apache/activemq-artemis/pull/3795#issuecomment-1031694156


   This idea has merit, but there a couple problems:
   
    - The code isn't formatted properly so CheckStyle is failing.
    - The retry is limited to `org.apache.activemq.artemis.core.io.nio.NIOSequentialFile#open(int, boolean)`, but there are several implementations of `org.apache.activemq.artemis.core.io.SequentialFile#open(int, boolean)` which might benefit from such a retry.
    - The configuration should be available from `broker.xml` rather than just a system property.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org