You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/08/24 13:47:30 UTC
[GitHub] [incubator-nuttx] v01d opened a new pull request #1635: nRF52: add support for RTC event handling
v01d opened a new pull request #1635:
URL: https://github.com/apache/incubator-nuttx/pull/1635
## Summary
Adds support for setting up events on RTC peripheral
## Impact
Add support for new feature.
## Testing
Used events and work correctly.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] v01d commented on a change in pull request #1635: nRF52: add support for RTC event handling
Posted by GitBox <gi...@apache.org>.
v01d commented on a change in pull request #1635:
URL: https://github.com/apache/incubator-nuttx/pull/1635#discussion_r475749463
##########
File path: arch/arm/src/nrf52/nrf52_rtc.h
##########
@@ -74,6 +76,18 @@ enum nrf52_rtc_irq_e
NRF52_RTC_INT_COMPARE3 = 5,
};
+/* RTC Events */
Review comment:
So you suggest removing the irq enum, leave the evt one and use that, right?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] raiden00pl commented on a change in pull request #1635: nRF52: add support for RTC event handling
Posted by GitBox <gi...@apache.org>.
raiden00pl commented on a change in pull request #1635:
URL: https://github.com/apache/incubator-nuttx/pull/1635#discussion_r475748137
##########
File path: arch/arm/src/nrf52/nrf52_rtc.h
##########
@@ -74,6 +76,18 @@ enum nrf52_rtc_irq_e
NRF52_RTC_INT_COMPARE3 = 5,
};
+/* RTC Events */
Review comment:
If that breaks someone's compilation, fixing it is trivial.
I think the name 'nrf52_rtc_evt_e' seems more appropriate.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] raiden00pl commented on a change in pull request #1635: nRF52: add support for RTC event handling
Posted by GitBox <gi...@apache.org>.
raiden00pl commented on a change in pull request #1635:
URL: https://github.com/apache/incubator-nuttx/pull/1635#discussion_r475723675
##########
File path: arch/arm/src/nrf52/nrf52_rtc.h
##########
@@ -74,6 +76,18 @@ enum nrf52_rtc_irq_e
NRF52_RTC_INT_COMPARE3 = 5,
};
+/* RTC Events */
Review comment:
Don't you think we should combine this with 'enum nrf52_rtc_irq_e' defined above ?
They carry the same information and there is no point in duplicating them.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] raiden00pl commented on a change in pull request #1635: nRF52: add support for RTC event handling
Posted by GitBox <gi...@apache.org>.
raiden00pl commented on a change in pull request #1635:
URL: https://github.com/apache/incubator-nuttx/pull/1635#discussion_r475765912
##########
File path: arch/arm/src/nrf52/nrf52_rtc.h
##########
@@ -74,6 +76,18 @@ enum nrf52_rtc_irq_e
NRF52_RTC_INT_COMPARE3 = 5,
};
+/* RTC Events */
Review comment:
> So you suggest removing the irq enum, leave the evt one and use that, right?
Exactly.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] v01d commented on a change in pull request #1635: nRF52: add support for RTC event handling
Posted by GitBox <gi...@apache.org>.
v01d commented on a change in pull request #1635:
URL: https://github.com/apache/incubator-nuttx/pull/1635#discussion_r475731850
##########
File path: arch/arm/src/nrf52/nrf52_rtc.h
##########
@@ -74,6 +76,18 @@ enum nrf52_rtc_irq_e
NRF52_RTC_INT_COMPARE3 = 5,
};
+/* RTC Events */
Review comment:
If I do that I risk breaking code which used those definitions. Not sure what is preferable.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] raiden00pl merged pull request #1635: nRF52: add support for RTC event handling
Posted by GitBox <gi...@apache.org>.
raiden00pl merged pull request #1635:
URL: https://github.com/apache/incubator-nuttx/pull/1635
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] v01d commented on a change in pull request #1635: nRF52: add support for RTC event handling
Posted by GitBox <gi...@apache.org>.
v01d commented on a change in pull request #1635:
URL: https://github.com/apache/incubator-nuttx/pull/1635#discussion_r475774388
##########
File path: arch/arm/src/nrf52/nrf52_rtc.h
##########
@@ -74,6 +76,18 @@ enum nrf52_rtc_irq_e
NRF52_RTC_INT_COMPARE3 = 5,
};
+/* RTC Events */
Review comment:
done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org