You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Enis Soztutar (JIRA)" <ji...@apache.org> on 2014/06/28 03:47:40 UTC

[jira] [Commented] (HBASE-10704) BaseLoadBalancer#roundRobinAssignment() may add same region to assignment plan multiple times

    [ https://issues.apache.org/jira/browse/HBASE-10704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14046617#comment-14046617 ] 

Enis Soztutar commented on HBASE-10704:
---------------------------------------

Attaching rebased patch for master that is committed

> BaseLoadBalancer#roundRobinAssignment() may add same region to assignment plan multiple times
> ---------------------------------------------------------------------------------------------
>
>                 Key: HBASE-10704
>                 URL: https://issues.apache.org/jira/browse/HBASE-10704
>             Project: HBase
>          Issue Type: Sub-task
>            Reporter: Ted Yu
>            Assignee: Ted Yu
>             Fix For: hbase-10070
>
>         Attachments: 0018-HBASE-10704-BaseLoadBalancer-roundRobinAssignment-ma.patch, 10704-v1.txt, 10704-v2.txt, hbase-10704_v3.patch
>
>
> I noticed the following exception in some unit tests:
> {code}
> 2014-03-09 03:38:13,523 WARN  [s111-s2.cs1cloud.internal,57347,1394350359795-GeneralBulkAssigner-2] master.GeneralBulkAssigner$SingleServerBulkAssigner(232): Failed bulking assigning 18 region(s) to s111.internal,46094,1394350360588, and continue to bulk assign others
> java.lang.NullPointerException
> 	at org.apache.hadoop.hbase.master.AssignmentManager.assign(AssignmentManager.java:1505)
> 	at org.apache.hadoop.hbase.master.GeneralBulkAssigner$SingleServerBulkAssigner.run(GeneralBulkAssigner.java:228)
> 	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
> 	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)
> 	at java.lang.Thread.run(Thread.java:722)
> {code}
> Here is related code:
> {code}
>           Lock lock = locks.remove(encodedName);
>           lock.unlock();
> {code}
> lock was null due to BaseLoadBalancer#roundRobinAssignment() adding same region to assignment plan multiple times.
> This happens in computing lastFewRegions where cluster.wouldLowerAvailability() returns true.



--
This message was sent by Atlassian JIRA
(v6.2#6252)