You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2025/09/29 19:54:21 UTC

[kudu-CR] [consensus] fix linkage failure on macOS

Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/23476


Change subject: [consensus] fix linkage failure on macOS
......................................................................

[consensus] fix linkage failure on macOS

A prior patch implementing KUDU-1973 has introduced DCHECK_EQ()
that wouldn't compile on macOS with clang, even if it completes
successfully on Linux.  I didn't try to find the difference in how
the glog in 3rd-party is built, but simply replaced DCHECK_EQ()
with equivalent DCHECK() and now build passes on macOS as well.

Before this patch, building the project on macOS would fail with an
error like below:

Undefined symbols for architecture x86_64:
  "void google::MakeCheckOpValueString<std::nullptr_t>(std::__1::basic_ostream<char, std::__1::char_traits<char>>*, std::nullptr_t const&)", referenced from:
      std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char>>* google::MakeCheckOpString<std::nullptr_t, std::__1::shared_ptr<kudu::rpc::PeriodicTimer>>(std::nullptr_t const&, std::__1::shared_ptr<kudu::rpc::PeriodicTimer> const&, char const*) in multi_raft_batcher.cc.o
ld: symbol(s) not found for architecture x86_64
clang: error: linker command failed with exit code 1 (use -v to see invocation)

[1] https://github.com/apache/kudu/commit/4999c30d1

Change-Id: I26d0b4c1149f2df92e0f8654f7dba654fa6e281d
---
M src/kudu/consensus/multi_raft_batcher.cc
1 file changed, 1 insertion(+), 1 deletion(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/76/23476/1
-- 
To view, visit http://gerrit.cloudera.org:8080/23476
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I26d0b4c1149f2df92e0f8654f7dba654fa6e281d
Gerrit-Change-Number: 23476
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>

[kudu-CR] [consensus] fix linkage failure on macOS

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/23476 )

Change subject: [consensus] fix linkage failure on macOS
......................................................................


Patch Set 1: Verified+1

unrelated failures of know flaky java tests:
  * RELEASE: org.apache.kudu.spark.kudu.DefaultSourceTest 	dist
  * TSAN: org.apache.kudu.client.TestKuduClient


-- 
To view, visit http://gerrit.cloudera.org:8080/23476
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I26d0b4c1149f2df92e0f8654f7dba654fa6e281d
Gerrit-Change-Number: 23476
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Martonka <zm...@cloudera.com>
Gerrit-Comment-Date: Mon, 29 Sep 2025 21:43:46 +0000
Gerrit-HasComments: No

[kudu-CR] [consensus] fix linkage failure on macOS

Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23476 )

Change subject: [consensus] fix linkage failure on macOS
......................................................................


Patch Set 1: Verified-1

Build Failed 

http://jenkins.kudu.apache.org/job/pre_commit/1889/ : FAILURE


-- 
To view, visit http://gerrit.cloudera.org:8080/23476
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I26d0b4c1149f2df92e0f8654f7dba654fa6e281d
Gerrit-Change-Number: 23476
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Martonka <zm...@cloudera.com>
Gerrit-Comment-Date: Mon, 29 Sep 2025 21:42:16 +0000
Gerrit-HasComments: No

[kudu-CR] [consensus] fix linkage failure on macOS

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/23476 )

Change subject: [consensus] fix linkage failure on macOS
......................................................................

[consensus] fix linkage failure on macOS

A prior patch implementing KUDU-1973 has introduced DCHECK_EQ()
that wouldn't compile on macOS with clang, even if it completes
successfully on Linux.  I didn't try to find the difference in how
the glog in 3rd-party is built, but simply replaced DCHECK_EQ()
with equivalent DCHECK() and now build passes on macOS as well.

Before this patch, building the project on macOS would fail with an
error like below:

Undefined symbols for architecture x86_64:
  "void google::MakeCheckOpValueString<std::nullptr_t>(std::__1::basic_ostream<char, std::__1::char_traits<char>>*, std::nullptr_t const&)", referenced from:
      std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char>>* google::MakeCheckOpString<std::nullptr_t, std::__1::shared_ptr<kudu::rpc::PeriodicTimer>>(std::nullptr_t const&, std::__1::shared_ptr<kudu::rpc::PeriodicTimer> const&, char const*) in multi_raft_batcher.cc.o
ld: symbol(s) not found for architecture x86_64
clang: error: linker command failed with exit code 1 (use -v to see invocation)

[1] https://github.com/apache/kudu/commit/4999c30d1

Change-Id: I26d0b4c1149f2df92e0f8654f7dba654fa6e281d
Reviewed-on: http://gerrit.cloudera.org:8080/23476
Reviewed-by: Zoltan Martonka <zm...@cloudera.com>
Tested-by: Alexey Serbin <al...@apache.org>
Reviewed-by: Abhishek Chennaka <ac...@cloudera.com>
---
M src/kudu/consensus/multi_raft_batcher.cc
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Zoltan Martonka: Looks good to me, but someone else must approve
  Alexey Serbin: Verified
  Abhishek Chennaka: Looks good to me, approved

-- 
To view, visit http://gerrit.cloudera.org:8080/23476
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I26d0b4c1149f2df92e0f8654f7dba654fa6e281d
Gerrit-Change-Number: 23476
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Martonka <zm...@cloudera.com>

[kudu-CR] [consensus] fix linkage failure on macOS

Posted by "Zoltan Martonka (Code Review)" <ge...@cloudera.org>.
Zoltan Martonka has posted comments on this change. ( http://gerrit.cloudera.org:8080/23476 )

Change subject: [consensus] fix linkage failure on macOS
......................................................................


Patch Set 1: Code-Review+1

Thank you.


-- 
To view, visit http://gerrit.cloudera.org:8080/23476
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I26d0b4c1149f2df92e0f8654f7dba654fa6e281d
Gerrit-Change-Number: 23476
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Martonka <zm...@cloudera.com>
Gerrit-Comment-Date: Mon, 29 Sep 2025 20:02:21 +0000
Gerrit-HasComments: No

[kudu-CR] [consensus] fix linkage failure on macOS

Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23476 )

Change subject: [consensus] fix linkage failure on macOS
......................................................................


Patch Set 1:

Build Started http://jenkins.kudu.apache.org/job/pre_commit/1889/


-- 
To view, visit http://gerrit.cloudera.org:8080/23476
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I26d0b4c1149f2df92e0f8654f7dba654fa6e281d
Gerrit-Change-Number: 23476
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Mon, 29 Sep 2025 19:54:30 +0000
Gerrit-HasComments: No

[kudu-CR] [consensus] fix linkage failure on macOS

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has removed a vote on this change.

Change subject: [consensus] fix linkage failure on macOS
......................................................................


Removed Verified-1 by Kudu Jenkins (120)
-- 
To view, visit http://gerrit.cloudera.org:8080/23476
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: I26d0b4c1149f2df92e0f8654f7dba654fa6e281d
Gerrit-Change-Number: 23476
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Martonka <zm...@cloudera.com>

[kudu-CR] [consensus] fix linkage failure on macOS

Posted by "Abhishek Chennaka (Code Review)" <ge...@cloudera.org>.
Abhishek Chennaka has posted comments on this change. ( http://gerrit.cloudera.org:8080/23476 )

Change subject: [consensus] fix linkage failure on macOS
......................................................................


Patch Set 1: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/23476
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I26d0b4c1149f2df92e0f8654f7dba654fa6e281d
Gerrit-Change-Number: 23476
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Martonka <zm...@cloudera.com>
Gerrit-Comment-Date: Mon, 29 Sep 2025 23:13:47 +0000
Gerrit-HasComments: No