You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Ekaterina Dimitrova (Jira)" <ji...@apache.org> on 2022/08/15 16:22:00 UTC
[jira] [Comment Edited] (CASSANDRA-17677) Fix BulkLoader to load entireSSTableThrottle and entireSSTableInterDcThrottle
[ https://issues.apache.org/jira/browse/CASSANDRA-17677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17579794#comment-17579794 ]
Ekaterina Dimitrova edited comment on CASSANDRA-17677 at 8/15/22 4:21 PM:
--------------------------------------------------------------------------
Thanks [~frankgh] , I just actually pulled your latest code and will be looking into it today.
About CI - I can confirm the failure in 4.1 is already seen in butler and unrelated, there is no ticket though - [https://ci-cassandra.apache.org/job/Cassandra-4.1/131/testReport/dtest-offheap.hintedhandoff_test/TestHintedHandoff/test_hintedhandoff_window/] We probably need to follow up on it where it came from as it seems new... But it is out of scope here.
You are right about the test_collection_function tests, seems they just started failing consistently last week. I will follow up on that as the patch after which they started failing shouldn't have broken them in theory but who knows... https://butler.cassandra.apache.org/#/ci/upstream/compare/Cassandra-trunk/trunk
I will post my review/approval later today.
was (Author: e.dimitrova):
Thanks [~frankgh] , I just actually pulled your latest code and will be looking into it today.
About CI - I can confirm the failure in 4.1 is already seen in butler and unrelated, there is no ticket though - [https://ci-cassandra.apache.org/job/Cassandra-4.1/131/testReport/dtest-offheap.hintedhandoff_test/TestHintedHandoff/test_hintedhandoff_window/] We probably need to follow up on it where it came from as it seems new... But it is out of scope here.
You are right about the test_collection_function tests, seems they just started failing consistently last week. I will follow up on that as the patch after which they started failing shouldn't have broken them in theory but who knows...
I will post my review/approval later today. https://butler.cassandra.apache.org/#/ci/upstream/compare/Cassandra-trunk/trunk
> Fix BulkLoader to load entireSSTableThrottle and entireSSTableInterDcThrottle
> ------------------------------------------------------------------------------
>
> Key: CASSANDRA-17677
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17677
> Project: Cassandra
> Issue Type: Bug
> Components: Tool/bulk load
> Reporter: Ekaterina Dimitrova
> Assignee: Francisco Guerrero
> Priority: Normal
> Fix For: 4.1-beta, 4.1.x, 4.x
>
> Time Spent: 8h
> Remaining Estimate: 0h
>
> {{entire_sstable_stream_throughput_outbound and entire_sstable_inter_dc_stream_throughput_outbound}} were introduced in CASSANDRA-17065.They were added to the LoaderOptions class but they are not loaded in BulkLoader as {{throttle}} and {{interDcThrottle are. }}{{As part of this ticket we need to fix the BulkLoader, also those properties should be advertised as MiB/s, not megabits/s. This was not changed in CASSANDRA-15234 for the bulk loader because those are not loaded and those variables in LoaderOptions are disconnected from the Cassandra config parameters and unused at the moment. }}
> It will be good also to update the doc here - [https://cassandra.apache.org/doc/latest/cassandra/operating/bulk_loading.html,|https://cassandra.apache.org/doc/latest/cassandra/operating/bulk_loading.html]
> {{and add a test that those are loaded properly when used with the BulkLoader. }}
> {{CC [~frankgh] }}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org