You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Dominic Hamon <dh...@twopensource.com> on 2014/04/22 20:48:57 UTC
Review Request 20563: Added defaultHistoryWindow based on
LIBPROCESS_STATISTICS_WINDOW.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20563/
-----------------------------------------------------------
Review request for mesos and Ben Mahler.
Repository: mesos-git
Description
-------
see summary.
we no longer have a global statistics object that manages history, instead each Metric has its own history. We can still support the environment variable by exposing a default history based on it that Metrics users can choose to use.
Diffs
-----
3rdparty/libprocess/include/process/metrics/metric.hpp 6a384ded8a4b57fd6aee819d0337773018c45669
3rdparty/libprocess/src/process.cpp 2439526a3c81ccda2b75cb239dc885a28a3b192c
3rdparty/libprocess/src/tests/metrics_tests.cpp abe1588c931b45a09294812974788aa74de44dd4
Diff: https://reviews.apache.org/r/20563/diff/
Testing
-------
make check.
Thanks,
Dominic Hamon
Re: Review Request 20563: Added defaultWindow to metrics based on
LIBPROCESS_STATISTICS_WINDOW.
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20563/#review46012
-----------------------------------------------------------
Patch looks great!
Reviews applied: [20563]
All tests passed.
- Mesos ReviewBot
On June 16, 2014, 6 p.m., Dominic Hamon wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20563/
> -----------------------------------------------------------
>
> (Updated June 16, 2014, 6 p.m.)
>
>
> Review request for mesos and Ben Mahler.
>
>
> Bugs: MESOS-1283
> https://issues.apache.org/jira/browse/MESOS-1283
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> see summary.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/include/process/metrics/metrics.hpp 0a97f12c9cdebb687bc7a80165a371fef62899b5
> 3rdparty/libprocess/src/metrics/metrics.cpp 38905d3e920288ac8c18ebed2743ebac9f438d2e
> 3rdparty/libprocess/src/process.cpp 0c0fca7acf870fdc7ca89d471cbff63af7799eef
> 3rdparty/libprocess/src/tests/metrics_tests.cpp 33539e45bab8f79afa773a325465016f01fd3b75
>
> Diff: https://reviews.apache.org/r/20563/diff/
>
>
> Testing
> -------
>
> make check.
>
>
> Thanks,
>
> Dominic Hamon
>
>
Re: Review Request 20563: Added defaultWindow to metrics based on
LIBPROCESS_STATISTICS_WINDOW.
Posted by Dominic Hamon <dh...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20563/
-----------------------------------------------------------
(Updated June 16, 2014, 11 a.m.)
Review request for mesos and Ben Mahler.
Changes
-------
rebased
Bugs: MESOS-1283
https://issues.apache.org/jira/browse/MESOS-1283
Repository: mesos-git
Description
-------
see summary.
Diffs (updated)
-----
3rdparty/libprocess/include/process/metrics/metrics.hpp 0a97f12c9cdebb687bc7a80165a371fef62899b5
3rdparty/libprocess/src/metrics/metrics.cpp 38905d3e920288ac8c18ebed2743ebac9f438d2e
3rdparty/libprocess/src/process.cpp 0c0fca7acf870fdc7ca89d471cbff63af7799eef
3rdparty/libprocess/src/tests/metrics_tests.cpp 33539e45bab8f79afa773a325465016f01fd3b75
Diff: https://reviews.apache.org/r/20563/diff/
Testing
-------
make check.
Thanks,
Dominic Hamon
Re: Review Request 20563: Added defaultWindow to metrics based on
LIBPROCESS_STATISTICS_WINDOW.
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20563/#review44462
-----------------------------------------------------------
Patch looks great!
Reviews applied: [20563]
All tests passed.
- Mesos ReviewBot
On May 30, 2014, 5:12 p.m., Dominic Hamon wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20563/
> -----------------------------------------------------------
>
> (Updated May 30, 2014, 5:12 p.m.)
>
>
> Review request for mesos and Ben Mahler.
>
>
> Bugs: MESOS-1283
> https://issues.apache.org/jira/browse/MESOS-1283
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> see summary.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/include/process/metrics/metrics.hpp 0a97f12c9cdebb687bc7a80165a371fef62899b5
> 3rdparty/libprocess/src/metrics/metrics.cpp 38905d3e920288ac8c18ebed2743ebac9f438d2e
> 3rdparty/libprocess/src/process.cpp 8501d2f08292d6790010ead58512376947ad53dc
> 3rdparty/libprocess/src/tests/metrics_tests.cpp 33539e45bab8f79afa773a325465016f01fd3b75
>
> Diff: https://reviews.apache.org/r/20563/diff/
>
>
> Testing
> -------
>
> make check.
>
>
> Thanks,
>
> Dominic Hamon
>
>
Re: Review Request 20563: Added defaultWindow to metrics based on
LIBPROCESS_STATISTICS_WINDOW.
Posted by Dominic Hamon <dh...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20563/
-----------------------------------------------------------
(Updated May 30, 2014, 10:12 a.m.)
Review request for mesos and Ben Mahler.
Changes
-------
rebased
Bugs: MESOS-1283
https://issues.apache.org/jira/browse/MESOS-1283
Repository: mesos-git
Description
-------
see summary.
Diffs (updated)
-----
3rdparty/libprocess/include/process/metrics/metrics.hpp 0a97f12c9cdebb687bc7a80165a371fef62899b5
3rdparty/libprocess/src/metrics/metrics.cpp 38905d3e920288ac8c18ebed2743ebac9f438d2e
3rdparty/libprocess/src/process.cpp 8501d2f08292d6790010ead58512376947ad53dc
3rdparty/libprocess/src/tests/metrics_tests.cpp 33539e45bab8f79afa773a325465016f01fd3b75
Diff: https://reviews.apache.org/r/20563/diff/
Testing
-------
make check.
Thanks,
Dominic Hamon
Re: Review Request 20563: Added defaultWindow to metrics based on
LIBPROCESS_STATISTICS_WINDOW.
Posted by Dominic Hamon <dh...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20563/
-----------------------------------------------------------
(Updated May 15, 2014, 10:59 a.m.)
Review request for mesos and Ben Mahler.
Changes
-------
rebased
Bugs: MESOS-1283
https://issues.apache.org/jira/browse/MESOS-1283
Repository: mesos-git
Description
-------
see summary.
Diffs (updated)
-----
3rdparty/libprocess/include/process/metrics/metrics.hpp 0a97f12c9cdebb687bc7a80165a371fef62899b5
3rdparty/libprocess/src/metrics/metrics.cpp 38905d3e920288ac8c18ebed2743ebac9f438d2e
3rdparty/libprocess/src/process.cpp 58bae5b0e26acacca7e43dbde291e7700a583fd9
3rdparty/libprocess/src/tests/metrics_tests.cpp 8a131218b858a6571bd520c470eac850a3fd345e
Diff: https://reviews.apache.org/r/20563/diff/
Testing
-------
make check.
Thanks,
Dominic Hamon
Re: Review Request 20563: Added defaultWindow to metrics based on
LIBPROCESS_STATISTICS_WINDOW.
Posted by Dominic Hamon <dh...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20563/
-----------------------------------------------------------
(Updated May 2, 2014, 10:51 a.m.)
Review request for mesos and Ben Mahler.
Changes
-------
added issue ref
Bugs: MESOS-1283
https://issues.apache.org/jira/browse/MESOS-1283
Repository: mesos-git
Description
-------
see summary.
Diffs
-----
3rdparty/libprocess/include/process/metrics/metrics.hpp d5176ee4375febff26f52f167ead39a8303b54f9
3rdparty/libprocess/src/metrics/metrics.cpp 43c605553cb6606a2eed081fecc1e37ee14cbde3
3rdparty/libprocess/src/process.cpp 26c16cf58c31102dc61b5844b3e4d75e5bc2764e
3rdparty/libprocess/src/tests/metrics_tests.cpp 6f3795b33b92dd0621867e274649f8b9667ba538
Diff: https://reviews.apache.org/r/20563/diff/
Testing
-------
make check.
Thanks,
Dominic Hamon
Re: Review Request 20563: Added defaultWindow to metrics based on
LIBPROCESS_STATISTICS_WINDOW.
Posted by Dominic Hamon <dh...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20563/
-----------------------------------------------------------
(Updated April 23, 2014, 12:26 p.m.)
Review request for mesos and Ben Mahler.
Changes
-------
use global initialization of metrics
Summary (updated)
-----------------
Added defaultWindow to metrics based on LIBPROCESS_STATISTICS_WINDOW.
Repository: mesos-git
Description (updated)
-------
see summary.
Diffs (updated)
-----
3rdparty/libprocess/include/process/metrics/metrics.hpp d5176ee4375febff26f52f167ead39a8303b54f9
3rdparty/libprocess/src/metrics/metrics.cpp 43c605553cb6606a2eed081fecc1e37ee14cbde3
3rdparty/libprocess/src/process.cpp 26c16cf58c31102dc61b5844b3e4d75e5bc2764e
3rdparty/libprocess/src/tests/metrics_tests.cpp 6f3795b33b92dd0621867e274649f8b9667ba538
Diff: https://reviews.apache.org/r/20563/diff/
Testing
-------
make check.
Thanks,
Dominic Hamon