[incubator-plc4x] branch master updated: - Fixed some more sonarqube findings

[cd...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

cdutz pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-plc4x.git


The following commit(s) were added to refs/heads/master by this push:
     new 0d75373  - Fixed some more sonarqube findings
0d75373 is described below

commit 0d7537376e8378e1df9764ade2426b5b686f9b34
Author: Christofer Dutz <ch...@c-ware.de>
AuthorDate: Fri Jan 26 14:11:52 2018 +0100

    - Fixed some more sonarqube findings
---
 .../src/main/java/org/apache/plc4x/java/api/connection/PlcReader.java   | 1 +
 .../src/main/java/org/apache/plc4x/java/api/connection/PlcWriter.java   | 2 +-
 .../plc4x/java/api/messages/specific/TypeSafePlcReadResponse.java       | 2 +-
 .../plc4x/java/api/messages/specific/TypeSafePlcWriteResponse.java      | 2 +-
 4 files changed, 4 insertions(+), 3 deletions(-)

diff --git a/plc4j/api/src/main/java/org/apache/plc4x/java/api/connection/PlcReader.java b/plc4j/api/src/main/java/org/apache/plc4x/java/api/connection/PlcReader.java
index 6702ded..7c76795 100644
--- a/plc4j/api/src/main/java/org/apache/plc4x/java/api/connection/PlcReader.java
+++ b/plc4j/api/src/main/java/org/apache/plc4x/java/api/connection/PlcReader.java
@@ -29,6 +29,7 @@ import java.util.concurrent.CompletableFuture;
 /**
  * Interface implemented by all PlcConnections that are able to read from remote resources.
  */
+@FunctionalInterface
 public interface PlcReader {
 
     /**
diff --git a/plc4j/api/src/main/java/org/apache/plc4x/java/api/connection/PlcWriter.java b/plc4j/api/src/main/java/org/apache/plc4x/java/api/connection/PlcWriter.java
index 12804c7..3307d51 100644
--- a/plc4j/api/src/main/java/org/apache/plc4x/java/api/connection/PlcWriter.java
+++ b/plc4j/api/src/main/java/org/apache/plc4x/java/api/connection/PlcWriter.java
@@ -30,6 +30,7 @@ import java.util.concurrent.CompletableFuture;
 /**
  * Interface implemented by all PlcConnections that are able to write to remote resources.
  */
+@FunctionalInterface
 public interface PlcWriter {
 
     /**
@@ -47,7 +48,6 @@ public interface PlcWriter {
      * @param <T>          type that is being requested.
      * @return a {@link CompletableFuture} giving async access to the response of the write operation.
      */
-    @SuppressWarnings("unchecked")
     default <T> CompletableFuture<TypeSafePlcWriteResponse<T>> write(TypeSafePlcWriteRequest<T> writeRequest) {
         Objects.requireNonNull(writeRequest, "write request must not be null");
         return write((PlcWriteRequest) writeRequest).thenApply(TypeSafePlcWriteResponse::of);
diff --git a/plc4j/api/src/main/java/org/apache/plc4x/java/api/messages/specific/TypeSafePlcReadResponse.java b/plc4j/api/src/main/java/org/apache/plc4x/java/api/messages/specific/TypeSafePlcReadResponse.java
index 6f09f31..f32e527 100644
--- a/plc4j/api/src/main/java/org/apache/plc4x/java/api/messages/specific/TypeSafePlcReadResponse.java
+++ b/plc4j/api/src/main/java/org/apache/plc4x/java/api/messages/specific/TypeSafePlcReadResponse.java
@@ -60,7 +60,7 @@ public class TypeSafePlcReadResponse<T> extends PlcReadResponse {
     }
 
     @SuppressWarnings("unchecked")
-    public static TypeSafePlcReadResponse of(PlcReadResponse plcReadResponse) {
+    public static <T> TypeSafePlcReadResponse<T> of(PlcReadResponse plcReadResponse) {
         if (plcReadResponse instanceof TypeSafePlcReadResponse) {
             return (TypeSafePlcReadResponse) plcReadResponse;
         }
diff --git a/plc4j/api/src/main/java/org/apache/plc4x/java/api/messages/specific/TypeSafePlcWriteResponse.java b/plc4j/api/src/main/java/org/apache/plc4x/java/api/messages/specific/TypeSafePlcWriteResponse.java
index 9186a67..ae636f1 100644
--- a/plc4j/api/src/main/java/org/apache/plc4x/java/api/messages/specific/TypeSafePlcWriteResponse.java
+++ b/plc4j/api/src/main/java/org/apache/plc4x/java/api/messages/specific/TypeSafePlcWriteResponse.java
@@ -54,7 +54,7 @@ public class TypeSafePlcWriteResponse<T> extends PlcWriteResponse {
     }
 
     @SuppressWarnings("unchecked")
-    public static TypeSafePlcWriteResponse of(PlcWriteResponse plcWriteResponse) {
+    public static <T> TypeSafePlcWriteResponse<T> of(PlcWriteResponse plcWriteResponse) {
         if (plcWriteResponse instanceof TypeSafePlcWriteResponse) {
             return (TypeSafePlcWriteResponse) plcWriteResponse;
         }

-- 
To stop receiving notification emails like this one, please contact
cdutz@apache.org.