[jira] Commented: (PIG-1497) Mandatory rule PartitionFilterOptimizer

["Richard Ding (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/PIG-1497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12900100#action_12900100 ] 

Richard Ding commented on PIG-1497:
-----------------------------------

Looks good. A few comments:

In _PartitionFilterPushDown_:

* In _check_ method, why changes the condition from

{code}
if(... || sucs.size() != 1 || ...) {
{code}

         to 

{code}
if(... || succeds.size() == 0 || ...)
{code}

* In _transform_ method, the original code

{code}
// remove this filter from the plan                  
mPlan.removeAndReconnect(loFilter);
{code}

is replaced by its own implementation. It seems better to also migrate the _removeAndReconnect_ to the new _OperatorPlan_ since the logic there is more complicated (keeping the order of connections). 

* The javadoc for the class isn't migrated.

* Several variables (e.g. loadFunc, loLoad, loFilter, ...) now have scope within the _PartitionFilterPushDownTransformer_ class, so it would be better to put them inside the transformer class.

In addition,

* Need to remove all the tabs from the files and replace them with 4 spaces.
* Several unit tests now fail due to the dependency on other jiras.

> Mandatory rule PartitionFilterOptimizer
> ---------------------------------------
>
>                 Key: PIG-1497
>                 URL: https://issues.apache.org/jira/browse/PIG-1497
>             Project: Pig
>          Issue Type: Sub-task
>          Components: impl
>    Affects Versions: 0.8.0
>            Reporter: Daniel Dai
>            Assignee: Xuefu Zhang
>             Fix For: 0.8.0
>
>         Attachments: jira-1497-0.patch
>
>
> Need to migrate PartitionFilterOptimizer to new logical optimizer.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.