You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/06/11 14:44:00 UTC
[GitHub] [incubator-superset] dpgaspar opened a new pull request #10039: fix(security): can_access with None crashes on builtin roles
dpgaspar opened a new pull request #10039:
URL: https://github.com/apache/incubator-superset/pull/10039
### SUMMARY
Calling `can_access` with `None` values causes an exception when using builtin roles. Will make this more resilient on FAB, but this should be fixed here also.
### ADDITIONAL INFORMATION
- [ ] Has associated issue:
- [ ] Changes UI
- [ ] Requires DB Migration.
- [ ] Confirm DB Migration upgrade and downgrade tested.
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #10039: fix(security): can_access with None crashes on builtin roles
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #10039:
URL: https://github.com/apache/incubator-superset/pull/10039#issuecomment-642709925
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10039?src=pr&el=h1) Report
> Merging [#10039](https://codecov.io/gh/apache/incubator-superset/pull/10039?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/91517a56a3bcacd4c8f2dca233d8df248bfca10e&el=desc) will **increase** coverage by `3.30%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/10039?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #10039 +/- ##
==========================================
+ Coverage 65.59% 68.90% +3.30%
==========================================
Files 585 584 -1
Lines 31046 31049 +3
Branches 3277 3180 -97
==========================================
+ Hits 20364 21393 +1029
+ Misses 10501 9547 -954
+ Partials 181 109 -72
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `53.85% <ø> (?)` | |
| #javascript | `59.48% <ø> (+0.11%)` | :arrow_up: |
| #python | `67.36% <100.00%> (-2.63%)` | :arrow_down: |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/10039?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/security/manager.py](https://codecov.io/gh/apache/incubator-superset/pull/10039/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc2VjdXJpdHkvbWFuYWdlci5weQ==) | `89.11% <100.00%> (+0.07%)` | :arrow_up: |
| [superset/connectors/druid/models.py](https://codecov.io/gh/apache/incubator-superset/pull/10039/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9kcnVpZC9tb2RlbHMucHk=) | `28.16% <0.00%> (-54.36%)` | :arrow_down: |
| [superset/db\_engine\_specs/postgres.py](https://codecov.io/gh/apache/incubator-superset/pull/10039/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3Bvc3RncmVzLnB5) | `97.29% <0.00%> (-2.71%)` | :arrow_down: |
| [superset/connectors/base/models.py](https://codecov.io/gh/apache/incubator-superset/pull/10039/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9iYXNlL21vZGVscy5weQ==) | `86.42% <0.00%> (-2.51%)` | :arrow_down: |
| [superset/views/datasource.py](https://codecov.io/gh/apache/incubator-superset/pull/10039/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YXNvdXJjZS5weQ==) | `91.80% <0.00%> (-1.64%)` | :arrow_down: |
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/10039/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `75.39% <0.00%> (-0.89%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/10039/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `48.27% <0.00%> (-0.16%)` | :arrow_down: |
| [superset/viz.py](https://codecov.io/gh/apache/incubator-superset/pull/10039/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6LnB5) | `57.06% <0.00%> (-0.09%)` | :arrow_down: |
| [superset/sql\_parse.py](https://codecov.io/gh/apache/incubator-superset/pull/10039/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3BhcnNlLnB5) | `99.28% <0.00%> (-0.02%)` | :arrow_down: |
| [superset/errors.py](https://codecov.io/gh/apache/incubator-superset/pull/10039/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXJyb3JzLnB5) | `100.00% <0.00%> (ø)` | |
| ... and [159 more](https://codecov.io/gh/apache/incubator-superset/pull/10039/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10039?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10039?src=pr&el=footer). Last update [91517a5...e81167e](https://codecov.io/gh/apache/incubator-superset/pull/10039?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #10039: fix(security): can_access with None crashes on builtin roles
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #10039:
URL: https://github.com/apache/incubator-superset/pull/10039#issuecomment-642709925
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10039?src=pr&el=h1) Report
> Merging [#10039](https://codecov.io/gh/apache/incubator-superset/pull/10039?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/91517a56a3bcacd4c8f2dca233d8df248bfca10e&el=desc) will **increase** coverage by `3.29%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/10039?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #10039 +/- ##
==========================================
+ Coverage 65.59% 68.89% +3.29%
==========================================
Files 585 584 -1
Lines 31046 31058 +12
Branches 3277 3180 -97
==========================================
+ Hits 20364 21396 +1032
+ Misses 10501 9553 -948
+ Partials 181 109 -72
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `53.85% <ø> (?)` | |
| #javascript | `59.48% <ø> (+0.11%)` | :arrow_up: |
| #python | `67.34% <100.00%> (-2.64%)` | :arrow_down: |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/10039?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/security/manager.py](https://codecov.io/gh/apache/incubator-superset/pull/10039/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc2VjdXJpdHkvbWFuYWdlci5weQ==) | `89.11% <100.00%> (+0.07%)` | :arrow_up: |
| [superset/connectors/druid/models.py](https://codecov.io/gh/apache/incubator-superset/pull/10039/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9kcnVpZC9tb2RlbHMucHk=) | `28.16% <0.00%> (-54.36%)` | :arrow_down: |
| [superset/connectors/base/models.py](https://codecov.io/gh/apache/incubator-superset/pull/10039/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9iYXNlL21vZGVscy5weQ==) | `86.42% <0.00%> (-2.51%)` | :arrow_down: |
| [superset/views/datasource.py](https://codecov.io/gh/apache/incubator-superset/pull/10039/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YXNvdXJjZS5weQ==) | `91.80% <0.00%> (-1.64%)` | :arrow_down: |
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/10039/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `75.39% <0.00%> (-0.89%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/10039/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `48.27% <0.00%> (-0.16%)` | :arrow_down: |
| [superset/viz.py](https://codecov.io/gh/apache/incubator-superset/pull/10039/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6LnB5) | `57.06% <0.00%> (-0.09%)` | :arrow_down: |
| [superset/sql\_parse.py](https://codecov.io/gh/apache/incubator-superset/pull/10039/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3BhcnNlLnB5) | `99.29% <0.00%> (-0.01%)` | :arrow_down: |
| [superset/viz\_sip38.py](https://codecov.io/gh/apache/incubator-superset/pull/10039/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6X3NpcDM4LnB5) | `0.00% <0.00%> (ø)` | |
| [superset/datasets/api.py](https://codecov.io/gh/apache/incubator-superset/pull/10039/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvYXBpLnB5) | `92.56% <0.00%> (ø)` | |
| ... and [157 more](https://codecov.io/gh/apache/incubator-superset/pull/10039/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10039?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10039?src=pr&el=footer). Last update [91517a5...e81167e](https://codecov.io/gh/apache/incubator-superset/pull/10039?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #10039: fix(security): can_access with None crashes on builtin roles
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #10039:
URL: https://github.com/apache/incubator-superset/pull/10039#issuecomment-642709925
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10039?src=pr&el=h1) Report
> Merging [#10039](https://codecov.io/gh/apache/incubator-superset/pull/10039?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/91517a56a3bcacd4c8f2dca233d8df248bfca10e&el=desc) will **increase** coverage by `5.48%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/10039?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #10039 +/- ##
==========================================
+ Coverage 65.59% 71.07% +5.48%
==========================================
Files 585 400 -185
Lines 31046 12856 -18190
Branches 3277 3180 -97
==========================================
- Hits 20364 9138 -11226
+ Misses 10501 3609 -6892
+ Partials 181 109 -72
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `53.85% <ø> (?)` | |
| #javascript | `59.48% <ø> (+0.11%)` | :arrow_up: |
| #python | `?` | |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/10039?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...uperset-frontend/src/views/chartList/ChartList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/10039/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL2NoYXJ0TGlzdC9DaGFydExpc3QudHN4) | `61.22% <0.00%> (ø)` | |
| [superset/views/utils.py](https://codecov.io/gh/apache/incubator-superset/pull/10039/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvdXRpbHMucHk=) | | |
| [superset/viz\_sip38.py](https://codecov.io/gh/apache/incubator-superset/pull/10039/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6X3NpcDM4LnB5) | | |
| [superset/legacy.py](https://codecov.io/gh/apache/incubator-superset/pull/10039/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbGVnYWN5LnB5) | | |
| [superset/db\_engine\_specs/impala.py](https://codecov.io/gh/apache/incubator-superset/pull/10039/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2ltcGFsYS5weQ==) | | |
| [superset/db\_engine\_specs/bigquery.py](https://codecov.io/gh/apache/incubator-superset/pull/10039/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2JpZ3F1ZXJ5LnB5) | | |
| [superset/connectors/druid/views.py](https://codecov.io/gh/apache/incubator-superset/pull/10039/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9kcnVpZC92aWV3cy5weQ==) | | |
| [superset/models/dashboard.py](https://codecov.io/gh/apache/incubator-superset/pull/10039/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2Rhc2hib2FyZC5weQ==) | | |
| [superset/extensions.py](https://codecov.io/gh/apache/incubator-superset/pull/10039/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXh0ZW5zaW9ucy5weQ==) | | |
| [superset/common/query\_context.py](https://codecov.io/gh/apache/incubator-superset/pull/10039/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbW9uL3F1ZXJ5X2NvbnRleHQucHk=) | | |
| ... and [325 more](https://codecov.io/gh/apache/incubator-superset/pull/10039/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10039?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10039?src=pr&el=footer). Last update [91517a5...e81167e](https://codecov.io/gh/apache/incubator-superset/pull/10039?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] dpgaspar commented on pull request #10039: fix(security): can_access with None crashes on builtin roles
Posted by GitBox <gi...@apache.org>.
dpgaspar commented on pull request #10039:
URL: https://github.com/apache/incubator-superset/pull/10039#issuecomment-642717938
True, I'm incrementally adding them on FAB also
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #10039: fix(security): can_access with None crashes on builtin roles
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #10039:
URL: https://github.com/apache/incubator-superset/pull/10039#issuecomment-642709925
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10039?src=pr&el=h1) Report
> Merging [#10039](https://codecov.io/gh/apache/incubator-superset/pull/10039?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/91517a56a3bcacd4c8f2dca233d8df248bfca10e&el=desc) will **increase** coverage by `5.00%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/10039?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #10039 +/- ##
==========================================
+ Coverage 65.59% 70.59% +5.00%
==========================================
Files 585 400 -185
Lines 31046 12856 -18190
Branches 3277 3180 -97
==========================================
- Hits 20364 9076 -11288
+ Misses 10501 3665 -6836
+ Partials 181 115 -66
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `53.07% <ø> (?)` | |
| #javascript | `59.48% <ø> (+0.11%)` | :arrow_up: |
| #python | `?` | |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/10039?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...uperset-frontend/src/views/chartList/ChartList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/10039/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL2NoYXJ0TGlzdC9DaGFydExpc3QudHN4) | `61.22% <0.00%> (ø)` | |
| [superset/db\_engine\_specs/db2.py](https://codecov.io/gh/apache/incubator-superset/pull/10039/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2RiMi5weQ==) | | |
| [superset/db\_engine\_specs/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/10039/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL19faW5pdF9fLnB5) | | |
| [superset/models/slice.py](https://codecov.io/gh/apache/incubator-superset/pull/10039/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL3NsaWNlLnB5) | | |
| [superset/charts/commands/bulk\_delete.py](https://codecov.io/gh/apache/incubator-superset/pull/10039/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2NvbW1hbmRzL2J1bGtfZGVsZXRlLnB5) | | |
| [superset/examples/paris.py](https://codecov.io/gh/apache/incubator-superset/pull/10039/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvcGFyaXMucHk=) | | |
| [superset/db\_engine\_specs/base.py](https://codecov.io/gh/apache/incubator-superset/pull/10039/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2Jhc2UucHk=) | | |
| [superset/examples/tabbed\_dashboard.py](https://codecov.io/gh/apache/incubator-superset/pull/10039/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvdGFiYmVkX2Rhc2hib2FyZC5weQ==) | | |
| [...t-frontend/src/explore/controlPanels/EventFlow.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10039/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29udHJvbFBhbmVscy9FdmVudEZsb3cuanN4) | | |
| [superset/charts/commands/update.py](https://codecov.io/gh/apache/incubator-superset/pull/10039/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2NvbW1hbmRzL3VwZGF0ZS5weQ==) | | |
| ... and [323 more](https://codecov.io/gh/apache/incubator-superset/pull/10039/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10039?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10039?src=pr&el=footer). Last update [91517a5...e81167e](https://codecov.io/gh/apache/incubator-superset/pull/10039?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] dpgaspar merged pull request #10039: fix(security): can_access with None crashes on builtin roles
Posted by GitBox <gi...@apache.org>.
dpgaspar merged pull request #10039:
URL: https://github.com/apache/incubator-superset/pull/10039
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #10039: fix(security): can_access with None crashes on builtin roles
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #10039:
URL: https://github.com/apache/incubator-superset/pull/10039#issuecomment-642709925
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10039?src=pr&el=h1) Report
> Merging [#10039](https://codecov.io/gh/apache/incubator-superset/pull/10039?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/91517a56a3bcacd4c8f2dca233d8df248bfca10e&el=desc) will **increase** coverage by `3.16%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/10039?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #10039 +/- ##
==========================================
+ Coverage 65.59% 68.75% +3.16%
==========================================
Files 585 584 -1
Lines 31046 31049 +3
Branches 3277 3180 -97
==========================================
+ Hits 20364 21348 +984
+ Misses 10501 9592 -909
+ Partials 181 109 -72
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `53.85% <ø> (?)` | |
| #javascript | `59.48% <ø> (+0.11%)` | :arrow_up: |
| #python | `67.11% <100.00%> (-2.87%)` | :arrow_down: |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/10039?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/security/manager.py](https://codecov.io/gh/apache/incubator-superset/pull/10039/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc2VjdXJpdHkvbWFuYWdlci5weQ==) | `88.77% <100.00%> (-0.27%)` | :arrow_down: |
| [superset/connectors/druid/models.py](https://codecov.io/gh/apache/incubator-superset/pull/10039/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9kcnVpZC9tb2RlbHMucHk=) | `28.16% <0.00%> (-54.36%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/incubator-superset/pull/10039/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `59.64% <0.00%> (-21.06%)` | :arrow_down: |
| [superset/utils/cache.py](https://codecov.io/gh/apache/incubator-superset/pull/10039/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY2FjaGUucHk=) | `48.00% <0.00%> (-20.00%)` | :arrow_down: |
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/10039/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `78.26% <0.00%> (-13.05%)` | :arrow_down: |
| [superset/views/database/validators.py](https://codecov.io/gh/apache/incubator-superset/pull/10039/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvdmFsaWRhdG9ycy5weQ==) | `78.94% <0.00%> (-5.27%)` | :arrow_down: |
| [superset/views/database/api.py](https://codecov.io/gh/apache/incubator-superset/pull/10039/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvYXBpLnB5) | `84.09% <0.00%> (-3.41%)` | :arrow_down: |
| [superset/db\_engine\_specs/postgres.py](https://codecov.io/gh/apache/incubator-superset/pull/10039/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3Bvc3RncmVzLnB5) | `97.29% <0.00%> (-2.71%)` | :arrow_down: |
| [superset/views/database/views.py](https://codecov.io/gh/apache/incubator-superset/pull/10039/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2Uvdmlld3MucHk=) | `87.17% <0.00%> (-2.57%)` | :arrow_down: |
| [superset/connectors/base/models.py](https://codecov.io/gh/apache/incubator-superset/pull/10039/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9iYXNlL21vZGVscy5weQ==) | `86.42% <0.00%> (-2.51%)` | :arrow_down: |
| ... and [169 more](https://codecov.io/gh/apache/incubator-superset/pull/10039/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10039?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10039?src=pr&el=footer). Last update [91517a5...e81167e](https://codecov.io/gh/apache/incubator-superset/pull/10039?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter commented on pull request #10039: fix(security): can_access with None crashes on builtin roles
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #10039:
URL: https://github.com/apache/incubator-superset/pull/10039#issuecomment-642709925
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10039?src=pr&el=h1) Report
> Merging [#10039](https://codecov.io/gh/apache/incubator-superset/pull/10039?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/91517a56a3bcacd4c8f2dca233d8df248bfca10e&el=desc) will **decrease** coverage by `6.11%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/10039?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #10039 +/- ##
==========================================
- Coverage 65.59% 59.48% -6.12%
==========================================
Files 585 400 -185
Lines 31046 12856 -18190
Branches 3277 3180 -97
==========================================
- Hits 20364 7647 -12717
+ Misses 10501 5031 -5470
+ Partials 181 178 -3
```
| Flag | Coverage Δ | |
|---|---|---|
| #javascript | `59.48% <ø> (+0.11%)` | :arrow_up: |
| #python | `?` | |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/10039?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/chart/chartAction.js](https://codecov.io/gh/apache/incubator-superset/pull/10039/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L2NoYXJ0QWN0aW9uLmpz) | `49.72% <0.00%> (-0.55%)` | :arrow_down: |
| [...rc/explore/components/controls/AnnotationLayer.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10039/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9Bbm5vdGF0aW9uTGF5ZXIuanN4) | `2.34% <0.00%> (-0.03%)` | :arrow_down: |
| [superset-frontend/src/setup/setupPlugins.ts](https://codecov.io/gh/apache/incubator-superset/pull/10039/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwUGx1Z2lucy50cw==) | `0.00% <0.00%> (ø)` | |
| [...uperset-frontend/src/views/chartList/ChartList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/10039/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL2NoYXJ0TGlzdC9DaGFydExpc3QudHN4) | `61.22% <0.00%> (ø)` | |
| [...rontend/src/explore/components/PropertiesModal.tsx](https://codecov.io/gh/apache/incubator-superset/pull/10039/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9Qcm9wZXJ0aWVzTW9kYWwudHN4) | `13.63% <0.00%> (ø)` | |
| [.../src/components/Select/WindowedSelect/windowed.tsx](https://codecov.io/gh/apache/incubator-superset/pull/10039/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvU2VsZWN0L1dpbmRvd2VkU2VsZWN0L3dpbmRvd2VkLnRzeA==) | `64.70% <0.00%> (ø)` | |
| [.../src/explore/components/controls/SelectControl.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10039/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9TZWxlY3RDb250cm9sLmpzeA==) | `81.11% <0.00%> (ø)` | |
| [superset/examples/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/10039/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvX19pbml0X18ucHk=) | | |
| [superset/models/sql\_types/presto\_sql\_types.py](https://codecov.io/gh/apache/incubator-superset/pull/10039/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL3NxbF90eXBlcy9wcmVzdG9fc3FsX3R5cGVzLnB5) | | |
| [superset/utils/dashboard\_import\_export.py](https://codecov.io/gh/apache/incubator-superset/pull/10039/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvZGFzaGJvYXJkX2ltcG9ydF9leHBvcnQucHk=) | | |
| ... and [185 more](https://codecov.io/gh/apache/incubator-superset/pull/10039/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10039?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10039?src=pr&el=footer). Last update [91517a5...e81167e](https://codecov.io/gh/apache/incubator-superset/pull/10039?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org