You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/09/07 04:12:08 UTC
[GitHub] [shardingsphere] FlyingZC opened a new pull request, #20847: Modify transaction integration test trigger conditions
FlyingZC opened a new pull request, #20847:
URL: https://github.com/apache/shardingsphere/pull/20847
Changes proposed in this pull request:
- Modify transaction integration test trigger conditions
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] FlyingZC commented on a diff in pull request #20847: Modify transaction integration test trigger conditions
Posted by GitBox <gi...@apache.org>.
FlyingZC commented on code in PR #20847:
URL: https://github.com/apache/shardingsphere/pull/20847#discussion_r964504976
##########
.github/workflows/it-transaction.yml:
##########
@@ -42,6 +50,8 @@ on:
- 'shardingsphere-test/shardingsphere-integration-test/shardingsphere-integration-test-env/**'
- 'shardingsphere-test/shardingsphere-integration-test/shardingsphere-integration-test-transaction/**'
- '!*.md'
+ schedule:
Review Comment:
You are right.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] taojintianxia commented on a diff in pull request #20847: Modify transaction integration test trigger conditions
Posted by GitBox <gi...@apache.org>.
taojintianxia commented on code in PR #20847:
URL: https://github.com/apache/shardingsphere/pull/20847#discussion_r964429064
##########
.github/workflows/it-transaction.yml:
##########
@@ -42,6 +50,8 @@ on:
- 'shardingsphere-test/shardingsphere-integration-test/shardingsphere-integration-test-env/**'
- 'shardingsphere-test/shardingsphere-integration-test/shardingsphere-integration-test-transaction/**'
- '!*.md'
+ schedule:
Review Comment:
schedule is not that useful here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] strongduanmu merged pull request #20847: Modify transaction integration test trigger conditions
Posted by GitBox <gi...@apache.org>.
strongduanmu merged PR #20847:
URL: https://github.com/apache/shardingsphere/pull/20847
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org