You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/04/21 20:52:09 UTC

[GitHub] [arrow] westonpace commented on a diff in pull request #12915: ARROW-16158: [C++][R] rename ARROW_ENGINE to ARROW_SUBSTRAIT

westonpace commented on code in PR #12915:
URL: https://github.com/apache/arrow/pull/12915#discussion_r855584263


##########
cpp/CMakeLists.txt:
##########
@@ -353,7 +353,7 @@ if(ARROW_CUDA
   set(ARROW_IPC ON)
 endif()
 
-if(ARROW_ENGINE)
+if(ARROW_SUBSTRAIT)

Review Comment:
   Yes.  In the future we could presumably add conditional-feature flags.  For example, if a Substrait file says the format is Parquet and the consumer was built without Parquet then reject the plan as invalid.  I created ARROW-16274 to track this.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org