[jira] [Commented] (SCM-971) GitExe - unstaged local changes overlooked in release:prepare check

["Michael Osipov (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SCM-971?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17420485#comment-17420485 ] 

Michael Osipov commented on SCM-971:
------------------------------------

This provider has been written ages ago. That's the result now.

> GitExe - unstaged local changes overlooked in release:prepare check
> -------------------------------------------------------------------
>
>                 Key: SCM-971
>                 URL: https://issues.apache.org/jira/browse/SCM-971
>             Project: Maven SCM
>          Issue Type: Bug
>          Components: maven-scm-provider-gitexe
>    Affects Versions: 1.12.0
>            Reporter: Ben Arnold
>            Priority: Minor
>
> The {{release:prepare}} goal checks for local modifications and is supposed to fail if it finds any.
> The GitExe provider is responsible for identifying local modifications. It detects staged local modifications as expected but it can't parse the status code that indicates a file has local modifications that are unstaged.
> Unstaged changes show up in the output of {{git status --porcelain}} tagged with a pair of question marks ({{??}}). GitStatusConsumer doesn't understand these output lines and logs them as warnings, but that doesn't cause {{release:prepare}} to fail.
> It looks like GitStatusConsumer needs to be enhanced so that it can parse unstaged lines in the {{git status --porcelain}} output. These unstaged messages need to be returned to ScmCheckModificationsPhase so that it can fail correctly.
> Note that two of these unstaged files are likely to be {{release.properties}} and {{pom.xml.releaseBackup}}. These are created by the release plugin itself and shouldn't cause the release preparation to fail.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)