[GitHub] [spark] cloud-fan commented on a change in pull request #34429: [WIP][SPARK-37150][SQL] Migrate DESCRIBE NAMESPACE to use V2 command by default

[GitBox <gi...@apache.org>]

cloud-fan commented on a change in pull request #34429:
URL: https://github.com/apache/spark/pull/34429#discussion_r738930469



##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/DescribeNamespaceExec.scala
##########
@@ -45,9 +45,13 @@ case class DescribeNamespaceExec(
 
     if (isExtended) {
       val properties = metadata.asScala -- CatalogV2Util.NAMESPACE_RESERVED_PROPERTIES
-      if (properties.nonEmpty) {
-        rows += toCatalystRow("Properties", properties.toSeq.mkString("(", ",", ")"))
-      }
+      val propertiesStr =
+        if (properties.isEmpty) {
+          ""
+        } else {
+          properties.toSeq.mkString("(", ", ", ")")
+        }
+      rows += toCatalystRow("Properties", propertiesStr)

Review comment:
       I think it's OK to make this behavior change (database -> namespace). People can still fallback to v1 command if needed.
   
   The tests need to be a bit more complicated though, to allow different results between v1 and v2 commands.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org