[GitHub] [cassandra] maedhroz commented on a change in pull request #1334: CASSANDRA-17165 Make waiting for session event persistence more reliable in SecondaryIndexTest#test_only_coordinator_chooses_index_for_query

[GitBox <gi...@apache.org>]

maedhroz commented on a change in pull request #1334:
URL: https://github.com/apache/cassandra/pull/1334#discussion_r753448433



##########
File path: test/distributed/org/apache/cassandra/distributed/test/SecondaryIndexTest.java
##########
@@ -43,9 +45,10 @@
     private static final int NUM_NODES = 3;
     private static final int REPLICATION_FACTOR = 1;
     private static final String CREATE_TABLE = "CREATE TABLE %s(k int, v int, PRIMARY KEY (k))";
-    private static final String CREATE_INDEX = "CREATE INDEX v_index ON %s(v)";
+    private static final String CREATE_INDEX = "CREATE INDEX v_index_%d ON %s(v)";

Review comment:
       Note: It didn't matter for the correctness of the test, but it seemed good hygiene to suffix the index names, which I think are global to the keyspace.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org