You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2021/02/18 17:57:06 UTC
[GitHub] [netbeans-mavenutils-nbm-maven-plugin] ebarboni opened a new pull request #17: remove pack200 from nbm-maven-plugin
ebarboni opened a new pull request #17:
URL: https://github.com/apache/netbeans-mavenutils-nbm-maven-plugin/pull/17
This is a PR to remove pack200 from the code of the plugin. Simple fix but important changes for the usage of the plugin.
For me the plugin needs to run on modern JDK and still compile on jdk8. But running on jdk14 is not possible due to pack200 removal.
This removal make future nbm-maven-plugin unable to deals with nbm generated before RELEASE113.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans-mavenutils-nbm-maven-plugin] JaroslavTulach commented on pull request #17: remove pack200 from nbm-maven-plugin
Posted by GitBox <gi...@apache.org>.
JaroslavTulach commented on pull request #17:
URL: https://github.com/apache/netbeans-mavenutils-nbm-maven-plugin/pull/17#issuecomment-781898969
Cannot the functionality stay there and just yield a decent build failure on JDK14+? If you want to compile on JDK14+ (which may also be desirable goal) then I suggest to modify the compiler section like this:
```
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-compiler-plugin</artifactId>
<version>3.8.1</version>
<dependencies>
<dependency>
<groupId>org.frgaal</groupId>
<artifactId>compiler-maven-plugin</artifactId>
<version>15.0.0</version>
</dependency>
</dependencies>
<configuration>
<compilerId>frgaal</compilerId>
<source>1.8</source>
<target>1.8</target>
</configuration>
</plugin>
```
That way the code is going to compile on any JDK8+ and the `pack200` functionality is going to work on any JDK <14.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans-mavenutils-nbm-maven-plugin] jtulach commented on a change in pull request #17: remove pack200 from nbm-maven-plugin
Posted by GitBox <gi...@apache.org>.
jtulach commented on a change in pull request #17:
URL: https://github.com/apache/netbeans-mavenutils-nbm-maven-plugin/pull/17#discussion_r579283403
##########
File path: src/main/java/org/apache/netbeans/nbm/CreateClusterAppMojo.java
##########
@@ -319,7 +325,24 @@ else if ( path.endsWith( ".external" ) ) // MNBMODULE-138
{
outstream = new BufferedOutputStream( new FileOutputStream( fl ) );
InputStream instream = jf.getInputStream( ent );
- IOUtil.copy( instream, outstream );
+ if ( ispack200 )
+ {
+ Pack200.Unpacker unp = Pack200.newUnpacker();
Review comment:
Eric, if you hit this line on JDK14+, then you get a `LinkageError` - it'd be better to catch it or prevent it and fail the build with proper "maven build exception".
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans-mavenutils-nbm-maven-plugin] ebarboni merged pull request #17: remove pack200 from nbm-maven-plugin
Posted by GitBox <gi...@apache.org>.
ebarboni merged pull request #17:
URL: https://github.com/apache/netbeans-mavenutils-nbm-maven-plugin/pull/17
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans-mavenutils-nbm-maven-plugin] ebarboni commented on a change in pull request #17: remove pack200 from nbm-maven-plugin
Posted by GitBox <gi...@apache.org>.
ebarboni commented on a change in pull request #17:
URL: https://github.com/apache/netbeans-mavenutils-nbm-maven-plugin/pull/17#discussion_r579311507
##########
File path: src/main/java/org/apache/netbeans/nbm/CreateClusterAppMojo.java
##########
@@ -319,7 +325,24 @@ else if ( path.endsWith( ".external" ) ) // MNBMODULE-138
{
outstream = new BufferedOutputStream( new FileOutputStream( fl ) );
InputStream instream = jf.getInputStream( ent );
- IOUtil.copy( instream, outstream );
+ if ( ispack200 )
+ {
+ Pack200.Unpacker unp = Pack200.newUnpacker();
Review comment:
Hope this is good now
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans-mavenutils-nbm-maven-plugin] neilcsmith-net commented on pull request #17: remove pack200 from nbm-maven-plugin
Posted by GitBox <gi...@apache.org>.
neilcsmith-net commented on pull request #17:
URL: https://github.com/apache/netbeans-mavenutils-nbm-maven-plugin/pull/17#issuecomment-782029650
> then one doesn't need the frgaal compiler at all.
Yes please! At least, I don't think frgaal should be used without considering concerns and ramifications that were brought up in eg. https://github.com/apache/netbeans/pull/2337
I'm not sure if I'd prefer if Maven took Ant's approach to `release` and ignored it, or I'm just fed up of adding the same profile configuration to multiple projects. If it solves the issue(?) then looks better to me.
Not sure I see why this functionality needs to stay? I assume from the change `RELEASE110` to `RELEASE113` that different releases of the plugin aren't keeping that much backward compatibility anyway?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans-mavenutils-nbm-maven-plugin] ebarboni commented on pull request #17: remove pack200 from nbm-maven-plugin
Posted by GitBox <gi...@apache.org>.
ebarboni commented on pull request #17:
URL: https://github.com/apache/netbeans-mavenutils-nbm-maven-plugin/pull/17#issuecomment-782036628
I think I will go for the profile option. Needs plugin version bump for javadoc but seems to work.
I do not understand on how it works but will the official release plugin compiled on jdk8 still work at runtime on jdk 14. It remove the pack200 automaticaly ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans-mavenutils-nbm-maven-plugin] ebarboni commented on pull request #17: remove pack200 from nbm-maven-plugin
Posted by GitBox <gi...@apache.org>.
ebarboni commented on pull request #17:
URL: https://github.com/apache/netbeans-mavenutils-nbm-maven-plugin/pull/17#issuecomment-781954419
@JaroslavTulach frgaal is ok for compilation of the plugin but the javadoc is not working that make site goal not usable :/.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans-mavenutils-nbm-maven-plugin] JaroslavTulach commented on pull request #17: remove pack200 from nbm-maven-plugin
Posted by GitBox <gi...@apache.org>.
JaroslavTulach commented on pull request #17:
URL: https://github.com/apache/netbeans-mavenutils-nbm-maven-plugin/pull/17#issuecomment-781972402
Alas, javadoc! That can be solved with "profiles":
```
<profiles>
<profile>
<activation>
<jdk>[9,)</jdk>
</activation>
<build>
<plugins>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-javadoc-plugin</artifactId>
<configuration>
<release>8</release>
</configuration>
</plugin>
</plugins>
</build>
</profile>
</profiles>
```
the same trick can be used with `maven-compiler-plugin` - e.g. set `<release>8</release>` when on JDK9+ - then one doesn't need the frgaal compiler at all.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists