You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Hasan Diwan (JIRA)" <ji...@apache.org> on 2009/10/02 22:15:23 UTC
[jira] Created: (LUCENE-1942) NUM_THREADS is a static member of
RunAddIndexesThreads and should be accessed in a static way
NUM_THREADS is a static member of RunAddIndexesThreads and should be accessed in a static way
---------------------------------------------------------------------------------------------
Key: LUCENE-1942
URL: https://issues.apache.org/jira/browse/LUCENE-1942
Project: Lucene - Java
Issue Type: Bug
Components: Other
Environment: Eclipse 3.4.2
Reporter: Hasan Diwan
Priority: Trivial
The summary contains the problem. No further description needed, I don't think.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Updated: (LUCENE-1942) NUM_THREADS is a static member of
RunAddIndexesThreads and should be accessed in a static way
Posted by "Hasan Diwan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-1942?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Hasan Diwan updated LUCENE-1942:
--------------------------------
Attachment: lucene.pat
Patch fixes the compile bugs outlined in the summary.
> NUM_THREADS is a static member of RunAddIndexesThreads and should be accessed in a static way
> ---------------------------------------------------------------------------------------------
>
> Key: LUCENE-1942
> URL: https://issues.apache.org/jira/browse/LUCENE-1942
> Project: Lucene - Java
> Issue Type: Bug
> Components: Other
> Environment: Eclipse 3.4.2
> Reporter: Hasan Diwan
> Priority: Trivial
> Attachments: lucene.pat
>
>
> The summary contains the problem. No further description needed, I don't think.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Commented: (LUCENE-1942) NUM_THREADS is a static member of
RunAddIndexesThreads and should be accessed in a static way
Posted by "Robert Muir (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-1942?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12769467#action_12769467 ]
Robert Muir commented on LUCENE-1942:
-------------------------------------
i'm not able to read this patch file either... to me it looks malformed. (all on one line?)
> NUM_THREADS is a static member of RunAddIndexesThreads and should be accessed in a static way
> ---------------------------------------------------------------------------------------------
>
> Key: LUCENE-1942
> URL: https://issues.apache.org/jira/browse/LUCENE-1942
> Project: Lucene - Java
> Issue Type: Bug
> Components: Other
> Environment: Eclipse 3.4.2
> Reporter: Hasan Diwan
> Priority: Trivial
> Attachments: lucene.pat
>
>
> The summary contains the problem. No further description needed, I don't think.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Commented: (LUCENE-1942) NUM_THREADS is a static member of
RunAddIndexesThreads and should be accessed in a static way
Posted by "Michael McCandless (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-1942?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12769456#action_12769456 ]
Michael McCandless commented on LUCENE-1942:
--------------------------------------------
Can you make a simple patch for this? (I don't use Eclipse). Thanks.
> NUM_THREADS is a static member of RunAddIndexesThreads and should be accessed in a static way
> ---------------------------------------------------------------------------------------------
>
> Key: LUCENE-1942
> URL: https://issues.apache.org/jira/browse/LUCENE-1942
> Project: Lucene - Java
> Issue Type: Bug
> Components: Other
> Environment: Eclipse 3.4.2
> Reporter: Hasan Diwan
> Priority: Trivial
> Attachments: lucene.pat
>
>
> The summary contains the problem. No further description needed, I don't think.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Commented: (LUCENE-1942) NUM_THREADS is a static member of
RunAddIndexesThreads and should be accessed in a static way
Posted by "Mark Miller (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-1942?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12769471#action_12769471 ]
Mark Miller commented on LUCENE-1942:
-------------------------------------
Its not only a binary file, but it clearly says at the start that its an eclipse patch.
> NUM_THREADS is a static member of RunAddIndexesThreads and should be accessed in a static way
> ---------------------------------------------------------------------------------------------
>
> Key: LUCENE-1942
> URL: https://issues.apache.org/jira/browse/LUCENE-1942
> Project: Lucene - Java
> Issue Type: Bug
> Components: Other
> Environment: Eclipse 3.4.2
> Reporter: Hasan Diwan
> Priority: Trivial
> Attachments: lucene.pat
>
>
> The summary contains the problem. No further description needed, I don't think.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Commented: (LUCENE-1942) NUM_THREADS is a static member of
RunAddIndexesThreads and should be accessed in a static way
Posted by "Mark Miller (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-1942?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12786708#action_12786708 ]
Mark Miller commented on LUCENE-1942:
-------------------------------------
This issue is on the chopping block - you still around Hasan?
> NUM_THREADS is a static member of RunAddIndexesThreads and should be accessed in a static way
> ---------------------------------------------------------------------------------------------
>
> Key: LUCENE-1942
> URL: https://issues.apache.org/jira/browse/LUCENE-1942
> Project: Lucene - Java
> Issue Type: Bug
> Components: Other
> Environment: Eclipse 3.4.2
> Reporter: Hasan Diwan
> Priority: Trivial
> Attachments: lucene.pat
>
>
> The summary contains the problem. No further description needed, I don't think.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Commented: (LUCENE-1942) NUM_THREADS is a static member of
RunAddIndexesThreads and should be accessed in a static way
Posted by "Uwe Schindler (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-1942?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12769477#action_12769477 ]
Uwe Schindler commented on LUCENE-1942:
---------------------------------------
I do not understand the whole problem. We have no compilation problems, so whats wrong?
> NUM_THREADS is a static member of RunAddIndexesThreads and should be accessed in a static way
> ---------------------------------------------------------------------------------------------
>
> Key: LUCENE-1942
> URL: https://issues.apache.org/jira/browse/LUCENE-1942
> Project: Lucene - Java
> Issue Type: Bug
> Components: Other
> Environment: Eclipse 3.4.2
> Reporter: Hasan Diwan
> Priority: Trivial
> Attachments: lucene.pat
>
>
> The summary contains the problem. No further description needed, I don't think.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Commented: (LUCENE-1942) NUM_THREADS is a static member of
RunAddIndexesThreads and should be accessed in a static way
Posted by "Michael McCandless (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-1942?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12769468#action_12769468 ]
Michael McCandless commented on LUCENE-1942:
--------------------------------------------
But the attachment here is a binary file -- I can't feed it to the "patch" command. If you have an svn command line client you should be able to just do "svn diff" > LUCENE-1924.patch and then post that.
> NUM_THREADS is a static member of RunAddIndexesThreads and should be accessed in a static way
> ---------------------------------------------------------------------------------------------
>
> Key: LUCENE-1942
> URL: https://issues.apache.org/jira/browse/LUCENE-1942
> Project: Lucene - Java
> Issue Type: Bug
> Components: Other
> Environment: Eclipse 3.4.2
> Reporter: Hasan Diwan
> Priority: Trivial
> Attachments: lucene.pat
>
>
> The summary contains the problem. No further description needed, I don't think.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Commented: (LUCENE-1942) NUM_THREADS is a static member of
RunAddIndexesThreads and should be accessed in a static way
Posted by "Mark Miller (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-1942?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12769485#action_12769485 ]
Mark Miller commented on LUCENE-1942:
-------------------------------------
Well if the title is self explanatory as said, it just means he wants to switch access to that variable to a static way, rather than from a given instance. (ie RunIndexAccessThreads.NUM_THREADS rather than runIndexAccessThreads.NUM_THREADS). Purists ;) But its in the tests it looks ... and the only access' like that are now commented out that I see ... and the patch is way too big - but perhaps thats all binary cruft :)
Its a nice mystery for now :)
> NUM_THREADS is a static member of RunAddIndexesThreads and should be accessed in a static way
> ---------------------------------------------------------------------------------------------
>
> Key: LUCENE-1942
> URL: https://issues.apache.org/jira/browse/LUCENE-1942
> Project: Lucene - Java
> Issue Type: Bug
> Components: Other
> Environment: Eclipse 3.4.2
> Reporter: Hasan Diwan
> Priority: Trivial
> Attachments: lucene.pat
>
>
> The summary contains the problem. No further description needed, I don't think.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Commented: (LUCENE-1942) NUM_THREADS is a static member of
RunAddIndexesThreads and should be accessed in a static way
Posted by "Hasan Diwan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-1942?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12769466#action_12769466 ]
Hasan Diwan commented on LUCENE-1942:
-------------------------------------
Patch files are independent of the platform they were generated on. Indeed, I generated the patch using svn diff, I merely use eclipse as a glorified text editor.
> NUM_THREADS is a static member of RunAddIndexesThreads and should be accessed in a static way
> ---------------------------------------------------------------------------------------------
>
> Key: LUCENE-1942
> URL: https://issues.apache.org/jira/browse/LUCENE-1942
> Project: Lucene - Java
> Issue Type: Bug
> Components: Other
> Environment: Eclipse 3.4.2
> Reporter: Hasan Diwan
> Priority: Trivial
> Attachments: lucene.pat
>
>
> The summary contains the problem. No further description needed, I don't think.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Commented: (LUCENE-1942) NUM_THREADS is a static member of
RunAddIndexesThreads and should be accessed in a static way
Posted by "Michael McCandless (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-1942?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12769483#action_12769483 ]
Michael McCandless commented on LUCENE-1942:
--------------------------------------------
bq. I do not understand the whole problem. We have no compilation problems, so whats wrong?
Right, I was curious what could be wrong, so, I wanted to look at the patch...
> NUM_THREADS is a static member of RunAddIndexesThreads and should be accessed in a static way
> ---------------------------------------------------------------------------------------------
>
> Key: LUCENE-1942
> URL: https://issues.apache.org/jira/browse/LUCENE-1942
> Project: Lucene - Java
> Issue Type: Bug
> Components: Other
> Environment: Eclipse 3.4.2
> Reporter: Hasan Diwan
> Priority: Trivial
> Attachments: lucene.pat
>
>
> The summary contains the problem. No further description needed, I don't think.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Resolved: (LUCENE-1942) NUM_THREADS is a static member of
RunAddIndexesThreads and should be accessed in a static way
Posted by "Mark Miller (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-1942?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mark Miller resolved LUCENE-1942.
---------------------------------
Resolution: Won't Fix
> NUM_THREADS is a static member of RunAddIndexesThreads and should be accessed in a static way
> ---------------------------------------------------------------------------------------------
>
> Key: LUCENE-1942
> URL: https://issues.apache.org/jira/browse/LUCENE-1942
> Project: Lucene - Java
> Issue Type: Bug
> Components: Other
> Environment: Eclipse 3.4.2
> Reporter: Hasan Diwan
> Priority: Trivial
> Attachments: lucene.pat
>
>
> The summary contains the problem. No further description needed, I don't think.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org