You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Jay Guo <gu...@gmail.com> on 2017/01/25 18:06:03 UTC
Review Request 55945: Added a `install` template method to support 8
arguments.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55945/
-----------------------------------------------------------
Review request for mesos and Benjamin Mahler.
Repository: mesos
Description
-------
ReregisterSlave method will need to take agent capabilities as the
eighth argument. So we need `install` to support 8 arguments.
Diffs
-----
3rdparty/libprocess/include/process/protobuf.hpp ad2f2322a5d431f017422c0f6c922fda57ee9dc2
Diff: https://reviews.apache.org/r/55945/diff/
Testing
-------
Thanks,
Jay Guo
Re: Review Request 55945: Added a `install` template method to
support 8 arguments.
Posted by Benjamin Mahler <bm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55945/#review163157
-----------------------------------------------------------
Ship it!
Ship It!
- Benjamin Mahler
On Jan. 26, 2017, 11:46 a.m., Jay Guo wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55945/
> -----------------------------------------------------------
>
> (Updated Jan. 26, 2017, 11:46 a.m.)
>
>
> Review request for mesos and Benjamin Mahler.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> ReregisterSlave method will need to take agent capabilities as the
> eighth argument. So we need `install` to support 8 arguments.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/include/process/protobuf.hpp ad2f2322a5d431f017422c0f6c922fda57ee9dc2
>
> Diff: https://reviews.apache.org/r/55945/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jay Guo
>
>
Re: Review Request 55945: Added a `install` template method to
support 8 arguments.
Posted by Jay Guo <gu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55945/
-----------------------------------------------------------
(Updated Jan. 26, 2017, 7:46 p.m.)
Review request for mesos and Benjamin Mahler.
Changes
-------
rebase
Repository: mesos
Description
-------
ReregisterSlave method will need to take agent capabilities as the
eighth argument. So we need `install` to support 8 arguments.
Diffs (updated)
-----
3rdparty/libprocess/include/process/protobuf.hpp ad2f2322a5d431f017422c0f6c922fda57ee9dc2
Diff: https://reviews.apache.org/r/55945/diff/
Testing
-------
Thanks,
Jay Guo